remove "checkorder" P2P command #1904

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_10_remove_getorder changing 4 files +3 −125

laanwj commented at 5:10 PM on October 3, 2012: member

This command is a leftover from send-to-IP transactions, which have been removed a long time ago.

Removes the last remaining GetBoolArg("-allowreceivebyip").
jgarzik commented at 5:41 PM on October 3, 2012: contributor
Good but incomplete. You should also remove:
1. "reply" message handling
2. mapRequests
3. PushRequest*() functions

remove "checkorder" and "reply" P2P commands

These command are a leftover from send-to-IP transactions, which have been
removed a long time ago.
Also removes CNode::mapRequests and CNode::PushRequests, as these were
only used for the mentioned commands.

529a4d4824

laanwj commented at 6:10 PM on October 3, 2012: member

Ok, even better, I think I got them all now.
jgarzik commented at 6:19 PM on October 3, 2012: contributor

ACK
BitcoinPullTester commented at 6:14 AM on October 6, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/529a4d4824136a00e63cd69831023b9c4dd6936b for binaries and test log.
sipa commented at 12:33 PM on October 7, 2012: member

ACK
Diapolo commented at 4:10 PM on October 7, 2012: none

Same here, I think such removal pulls should get into 0.7.1.
gmaxwell commented at 6:33 PM on October 25, 2012: contributor

ACK.
gavinandresen commented at 6:34 PM on October 25, 2012: contributor

ACK
sipa referenced this in commit 344620e953 on Oct 25, 2012
sipa merged this on Oct 25, 2012
sipa closed this on Oct 25, 2012
laudney referenced this in commit 89daa65ba6 on Mar 19, 2014
laanwj deleted the branch on Apr 9, 2014
KolbyML referenced this in commit 92035f80fe on Dec 5, 2020
KolbyML referenced this in commit 2dc9704ba2 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)