Don't limit fuzzing inputs to 1 MB for afl-fuzz.
This change provides a level playing field for all fuzzers which allows for fair benchmarking using projects such as the excellent FuzzBench project.
Prior to this commit we limited afl-fuzz to ≤1 MB inputs but allowed unlimited length inputs for all other fuzzers.
ACK 6a239e72eb403d3ac5c7db203c5b3a24ef49a48b The maximum data size should be a runtime option, not a compile time hardcoded value.
18 | @@ -19,8 +19,6 @@ static bool read_stdin(std::vector<uint8_t>& data) 19 | ssize_t length = 0; 20 | while ((length = read(STDIN_FILENO, buffer, 1024)) > 0) { 21 | data.insert(data.end(), buffer, buffer + length); 22 | - 23 | - if (data.size() > (1 << 20)) return false; 24 | } 25 | return length == 0;
Why is length == 0 invalid? Seems overly restrictive.
It is the other way around: length != 0 is invalid. length == 0 means that end of file was reached which is what we want :)