QRCode address in image is not readable #19103

1. 
   jonasschnelli commented at 7:55 AM on May 29, 2020: contributor

   Somehow the resolution of the QRCode image is not high enough. Native wpkh addresses are non readable and legacy/p2sh addresses are not good readable. Haven't tested on other OSes than macOS.

   <img width="599" alt="Bildschirmfoto 2020-05-29 um 09 52 07" src="https://user-images.githubusercontent.com/178464/83235531-55807300-a192-11ea-8c5c-0f88481ecad1.png">

   <img width="599" alt="Bildschirmfoto 2020-05-29 um 09 53 21" src="https://user-images.githubusercontent.com/178464/83235524-51ecec00-a192-11ea-8cb3-bcd580724be6.png">

2. jonasschnelli added the label Bug on May 29, 2020
3. jonasschnelli added the label GUI on May 29, 2020
4. 
   BitcoinCorp commented at 9:13 AM on May 29, 2020: none

   not good since 0.19 on macOS

5. 
   promag commented at 9:16 AM on May 29, 2020: member

   This might be an issue with the font used. Anyway, why not remove the address from the image? It's shown below.

   Edit: nm, because save image.

6. 
   promag commented at 11:27 AM on May 29, 2020: member

   I've comment out

           // calculate ideal font size
           qreal font_size = GUIUtil::calculateIdealFontSize(paddedRect.width() - 20, text, font);
           font.setPointSizeF(font_size);
   

   So it would use the default font size and also sucks. On my system the point size of QFontDatabase::FixedFont is 10 and only with antialias it displays fine.

   I'm not sure if the idea is to have pixel perfect text, but in that case maybe we should ship with such font so that it's the same in all platforms?

   Otherwise we could a) use a better font b) enable antialias c) increase image size

   ping @luke-jr.

7. 
   fanquake commented at 9:55 AM on August 14, 2020: member

   Moved to the GUI repo: https://github.com/bitcoin-core/gui/issues/54.

8. fanquake closed this on Aug 14, 2020

   ---

9. jonasschnelli added this to the milestone 0.21.0 on Oct 23, 2020
10. jonasschnelli referenced this in commit 49984b44cf on Oct 23, 2020
11. sidhujag referenced this in commit a4909c6b06 on Oct 23, 2020
12. DrahtBot locked this on Feb 15, 2022

Milestone
0.21.0