test: Explain that a bug should be filed when the tests fail #19110

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2005-testBug changing 2 files +6 −0

MarcoFalke commented at 7:33 PM on May 29, 2020: member

Without a bug report it is harder to fix the issue
test: Explain that a bug should be filed when the test fail fad21a1a7a
MarcoFalke force-pushed on May 29, 2020
DrahtBot added the label Build system on May 29, 2020
DrahtBot added the label Tests on May 29, 2020
hebasto approved
hebasto commented at 6:33 AM on May 30, 2020: member

ACK fad21a1a7aa8804f4699e5821f074f5d3845c78b, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged.
fanquake approved

fanquake commented at 8:20 AM on May 30, 2020: member

ACK fad21a1a7aa8804f4699e5821f074f5d3845c78b

    assert_equal(self.nodes[0].getbestblockhash(), block.blahblah)
AttributeError: 'CBlock' object has no attribute 'blahblah'
2020-05-30T07:58:41.461000Z TestFramework (INFO): Stopping nodes
2020-05-30T07:58:41.724000Z TestFramework (WARNING): Not cleaning up dir /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/test_runner_₿_🏃_20200530_155836/feature_cltv_0
2020-05-30T07:58:41.724000Z TestFramework (ERROR): Test failed. Test logging available at /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/test_runner_₿_🏃_20200530_155836/feature_cltv_0/test_framework.log
2020-05-30T07:58:41.725000Z TestFramework (ERROR): 
2020-05-30T07:58:41.725000Z TestFramework (ERROR): Hint: Call /bitcoin/test/functional/combine_logs.py '/var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/test_runner_₿_🏃_20200530_155836/feature_cltv_0' to consolidate all logs
2020-05-30T07:58:41.725000Z TestFramework (ERROR): 
2020-05-30T07:58:41.725000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2020-05-30T07:58:41.725000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2020-05-30T07:58:41.725000Z TestFramework (ERROR):

MarcoFalke merged this on May 30, 2020
MarcoFalke closed this on May 30, 2020
MarcoFalke deleted the branch on May 30, 2020
hebasto commented at 5:56 AM on June 2, 2020: member

@MarcoFalke How to preserve the travis log with an intermittent error for issue submitting? e.g., https://travis-ci.org/github/bitcoin/bitcoin/jobs/692067912#L5040

If I re-run build the log pointed by url will be re-written. Re-submit the latest commit?
MarcoFalke commented at 10:29 AM on June 2, 2020: member

Yes, only way is to (force) push or re-open or download manually :( See #15847 (comment)
Fabcien referenced this in commit db540ee053 on Feb 24, 2021
PastaPastaPasta referenced this in commit e7955bea24 on Dec 22, 2021
PastaPastaPasta referenced this in commit 8a5c30d212 on Dec 22, 2021
PastaPastaPasta referenced this in commit e7ae05ee39 on Dec 22, 2021
PastaPastaPasta referenced this in commit baebdd2768 on Dec 28, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels