gui: add missing translation.h include to fix build #19231

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:translations_gui_fixup changing 1 files +1 −0

fanquake commented at 2:13 AM on June 10, 2020: member

After #19176, building the gui on Bionic is failing with:

  CXX      qt/qt_libbitcoinqt_a-guiutil.o
qt/bitcoin.cpp: In function 'int GuiMain(int, char**)':
qt/bitcoin.cpp:460:35: error: 'Untranslated' was not declared in this scope
           node->initError(strprintf(Untranslated("Error parsing command line arguments: %s\n"), error));

The merge commit also failed to compile with the same error: https://travis-ci.org/github/bitcoin/bitcoin/jobs/696627543

gui: add missing translation.h include to fix build

After #19176, building the gui on Bionic is failing with:

```bash
  CXX      qt/qt_libbitcoinqt_a-guiutil.o
qt/bitcoin.cpp: In function 'int GuiMain(int, char**)':
qt/bitcoin.cpp:460:35: error: 'Untranslated' was not declared in this scope
node->initError(strprintf(Untranslated("Error parsing command line arguments: %s\n"), error));
```

The merge commit also failed to compile with the same error:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/696627543

948f1134bc

fanquake added the label GUI on Jun 10, 2020
hebasto approved
hebasto commented at 6:11 AM on June 10, 2020: member

ACK 948f1134bc7b8ea1fb3c6b55f0cda16cc8dec126, tested on Linux Mint 19.3 (x86_64): it fixes compiling error with the --disable-wallet configure option.

While testing #19176 I compiled with both GCC and Clang, but did not try the --disable-wallet configure option. Sorry for that.
fanquake merged this on Jun 10, 2020
fanquake closed this on Jun 10, 2020
fanquake deleted the branch on Jun 10, 2020
MarcoFalke commented at 10:13 AM on June 10, 2020: member

I had missed that travis did not run this pull or did not report the result. Travis' only purpose is to compile pull requests and if it doesn't do that, we should remove it.
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19176 refactor: Error message bilingual_str consistency