build: remove BIP70 configure option #19257

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_bip70_configure changing 1 files +0 −10

fanquake commented at 7:57 AM on June 12, 2020: member

This was left in after #17165, so that anyone who had been compiling with (already disabled by default) BIP70 would realise that support had been completely removed in 0.20.0. However we should be able to remove it for 0.21.0.

build: remove BIP70 configure option

This was left in after #17165, so that anyone who had been compiling
with (already disabled by default) BIP70 would realise that support
had been completely removed in 0.20.0. However we should be able to
remove it for 0.21.0.

c4ffcf07af

fanquake added the label Build system on Jun 12, 2020
Sjors commented at 9:47 AM on June 12, 2020: member

Given that ./configure doesn't fail for unrecognised options, I have light preference for keeping this error. Though I doubt anyone uses it.
laanwj commented at 10:34 AM on June 12, 2020: member

Given that ./configure doesn't fail for unrecognised options, I have light preference for keeping this error. Though I doubt anyone uses it.

I somewhat agree. I think this special case should be removed (why does an unsupported option have a help string?!?), though replaced with a catch-all to reject formerly supported arguments.

Ideally there would a way to get ./configure to reject all unknown options (while still allowing, somehow, to pass configure arguments to subtrees).
jnewbery commented at 1:43 AM on June 13, 2020: member

utACK c4ffcf07af19cd0c600b11dabd94e7e9d31ad072
MarcoFalke commented at 11:42 AM on June 13, 2020: member

ACK c4ffcf07af19cd0c600b11dabd94e7e9d31ad072 with or without the "catch-all reject"
laanwj commented at 2:28 PM on July 1, 2020: member

with or without the "catch-all reject"

Handing unrecognized arguments in configure can be left for another PR I guess.
laanwj merged this on Jul 1, 2020
laanwj closed this on Jul 1, 2020
fanquake deleted the branch on Jul 2, 2020
sidhujag referenced this in commit 2790fd2b3b on Jul 8, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17165 Remove BIP70 support