doc: improve subtree check instructions #19258

1. 
   Sjors commented at 10:41 am on June 12, 2020: member

   Running git-subtree-check.sh requires adding the subtree repository as a remote. I learned that several years ago and then forgot again.

   This PR also improves the error message if the subtree commit can’t be found.

2. fanquake added the label Docs on Jun 12, 2020
3. fanquake added the label Scripts and tools on Jun 12, 2020
4. doc: improve subtree check instructions a4a3fc4cd2
5. in test/lint/README.md:29 in 117f69dfc3 outdated

   22@@ -23,6 +23,12 @@ maintained:
   23 * for `src/crypto/ctaes`: https://github.com/bitcoin-core/ctaes.git (branch master)
   24 * for `src/crc32c`: https://github.com/google/crc32c.git (branch master)
   25 
   26+To do so, add the upstream repository as remote:
   27+
   28+```
   29+git remote add -f secp256k1 https://github.com/bitcoin-core/secp256k1.git
   

   ---

   ---

   

   MarcoFalke commented at 11:08 am on June 12, 2020:

   I wish -f was called --fetch instead

   ---

   

   Sjors commented at 11:32 am on June 12, 2020:

   Changed.

   ---

   

   MarcoFalke commented at 11:53 am on June 12, 2020:

   Oh, I didn’t know --fetch existed. git help remote doesn’t mention it, but it seems to work, so :man_shrugging:

   ---

   

   Sjors commented at 12:29 pm on June 12, 2020:

   It does does show up when you do git remote add
6. Sjors force-pushed on Jun 12, 2020
7. fanquake approved
8. 
   fanquake commented at 6:58 am on June 29, 2020: member

   ACK a4a3fc4cd2e6f53cdffcc2962fd152a4e40c7413 - this looks ok.
9. 
   laanwj commented at 3:52 pm on July 9, 2020: member

   ACK a4a3fc4cd2e6f53cdffcc2962fd152a4e40c7413
10. laanwj merged this on Jul 9, 2020
11. laanwj closed this on Jul 9, 2020

    ---

12. sidhujag referenced this in commit e86e278263 on Jul 9, 2020
13. zkbot referenced this in commit caed4adf50 on Nov 10, 2020
14. DrahtBot locked this on Feb 15, 2022

Contributors
Sjors MarcoFalke fanquake laanwj

Labels
Docs Scripts and tools