This simplifies how omitted args are passed into the rpc help manager.
Previously, omitted named args had to be passed in as OMITTED_NAMED_ARG
. However, the rpc help manager already knows when an arg is a top level argument. Thus, OMITTED_NAMED_ARG
can simply be replaced by OMITTED
.
Some calls have been using the omitted-enum incorrectly, thus the rendered diff (effect of the changes here) is:
0diff --git a/createwallet b/createwallet
1index 539552e..677a15c 100644
2--- a/createwallet
3+++ b/createwallet
4@@ -6,7 +6,7 @@ Arguments:
5 1. wallet_name (string, required) The name for the new wallet. If this is a path, the wallet will be created at the path location.
6 2. disable_private_keys (boolean, optional, default=false) Disable the possibility of private keys (only watchonlys are possible in this mode).
7 3. blank (boolean, optional, default=false) Create a blank wallet. A blank wallet has no keys or HD seed. One can be set using sethdseed.
8-4. passphrase (string) Encrypt the wallet with this passphrase.
9+4. passphrase (string, optional) Encrypt the wallet with this passphrase.
10 5. avoid_reuse (boolean, optional, default=false) Keep track of coin reuse, and treat dirty and clean coins differently with privacy considerations in mind.
11 6. descriptors (boolean, optional, default=false) Create a native descriptor wallet. The wallet will use descriptors internally to handle address creation
12
13diff --git a/getblocktemplate b/getblocktemplate
14index 24368b1..9f38068 100644
15--- a/getblocktemplate
16+++ b/getblocktemplate
17@@ -11,8 +11,8 @@ For full specification, see BIPs 22, 23, 9, and 145:
18 Arguments:
19 1. template_request (json object, optional, default={}) Format of the template
20 {
21- "mode": "str", (string, optional) This must be set to "template", "proposal" (see BIP 23), or omitted
22- "capabilities": [ (json array, optional) A list of strings
23+ "mode": "str", (string) This must be set to "template", "proposal" (see BIP 23), or omitted
24+ "capabilities": [ (json array) The capabilities, can be omitted
25 "support", (string) client side supported feature, 'longpoll', 'coinbasetxn', 'coinbasevalue', 'proposal', 'serverlist', 'workid'
26 ...
27 ],
28diff --git a/scantxoutset b/scantxoutset
29index 1f166fb..b09e533 100644
30--- a/scantxoutset
31+++ b/scantxoutset
32@@ -21,7 +21,7 @@ Arguments:
33 "start" for starting a scan
34 "abort" for aborting the current scan (returns true when abort was successful)
35 "status" for progress report (in %) of the current scan
36-2. scanobjects (json array) Array of scan objects. Required for "start" action
37+2. scanobjects (json array, optional) Array of scan objects. Required for "start" action
38 Every scan object is either a string descriptor or an object:
39 [
40 "descriptor", (string) An output descriptor