Follow up from recent libsecp256k1 subtree update #19263

1. 
   fanquake commented at 1:55 am on June 13, 2020: member

   Opening this to track the potential followups, mentioned by @real-or-random, after the libsecp256k1 update in #19228.

   If we do those two changes (the second change belonging to this repo), we will have a clean copy of ecdsa_signature_parse_der_lax again. But maybe this is non-trivial enough to go to a second PR. I’m volunteering to open a PR after I digged through all the stuff now.

   comment:

   @real-or-random Thanks for pointing that out. I added a commit to rename privkey to seckey in key.cpp (as a scripted diff). I’ve left the DER parsing code be for now, as it seems unclear what changes to address where.

   comment:

   I’ve left the DER parsing code be for now, as it seems unclear what changes to address where.

   Ok, let’s do this in a different PR.

2. fanquake added the label Upstream on Jun 13, 2020
3. fanquake added the label Utils/log/libs on Jun 13, 2020
4. 
   real-or-random commented at 0:21 am on June 25, 2020: member

   I’ll be gone for a few days but my plan is to first to get a clean version upstream (https://github.com/bitcoin-core/secp256k1/issues/758) and then PR the clean version here.
5. 
   MarcoFalke commented at 7:41 pm on March 24, 2022: member

   Is this still an issue?
6. 
   real-or-random commented at 4:53 pm on March 28, 2022: member

   Yeah, this is still an issue. It’s not the end of the world, but we should track it somewhere. Having said this, it may be easier to track the issue only in https://github.com/bitcoin-core/secp256k1/issues/758. So we could close this issue here because it’s not directly relevant to Core.

   Status: My attempt to solve it (https://github.com/bitcoin-core/secp256k1/pull/781) didn’t get traction. Maybe I could try to open another PR which is less aggressive.

7. 
   fanquake commented at 6:46 pm on March 28, 2022: member

   Having said this, it may be easier to track the issue only in https://github.com/bitcoin-core/secp256k1/issues/758.

   Ok. Lets track upstream for now.

8. fanquake closed this on Mar 28, 2022

   ---

9. DrahtBot locked this on Mar 28, 2023

Contributors
fanquake real-or-random MarcoFalke

Labels
Upstream Utils/log/libs