[tests] Don’t import asyncio to test magic bytes #19264

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2020-06-magic-bytes-test changing 1 files +8 −21
  1. jnewbery commented at 2:56 am on June 13, 2020: member
    Simplify the test for invalid start bytes. No need to import asyncio and the Network thread.
  2. fanquake added the label Tests on Jun 13, 2020
  3. MarcoFalke commented at 11:38 am on June 13, 2020: member
    Concept ACK. Nice simplification, but it looks like the tests no longer pass after this change.
  4. [tests] Don't import asyncio to test magic bytes 49236be099
  5. jnewbery force-pushed on Jun 13, 2020
  6. jnewbery commented at 2:49 pm on June 13, 2020: member
    oops. Fixed.
  7. MarcoFalke commented at 4:45 pm on June 13, 2020: member
    review ACK 49236be099c5e8b3cadbc98d5216313e7e1a5a45
  8. fanquake commented at 1:18 am on June 14, 2020: member
  9. jonatack commented at 4:13 am on June 14, 2020: member
    ACK 49236be099c5e8b3cadbc98d5216313e7e1a5a45
  10. troygiorshev commented at 4:43 am on June 14, 2020: contributor
    ACK 49236be. +0.1 on the additional cut_len reformat.
  11. fanquake merged this on Jun 14, 2020
  12. fanquake closed this on Jun 14, 2020

  13. MarcoFalke referenced this in commit 67881de0e3 on Jun 24, 2020
  14. Fabcien referenced this in commit b97f1a9415 on May 13, 2021
  15. random-zebra referenced this in commit bffe509aed on Jun 28, 2021
  16. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me