[tests] Don't import asyncio to test magic bytes #19264

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2020-06-magic-bytes-test changing 1 files +8 −21

jnewbery commented at 2:56 AM on June 13, 2020: member

Simplify the test for invalid start bytes. No need to import asyncio and the Network thread.
fanquake added the label Tests on Jun 13, 2020
MarcoFalke commented at 11:38 AM on June 13, 2020: member

Concept ACK. Nice simplification, but it looks like the tests no longer pass after this change.
[tests] Don't import asyncio to test magic bytes 49236be099
jnewbery force-pushed on Jun 13, 2020
jnewbery commented at 2:49 PM on June 13, 2020: member

oops. Fixed.
MarcoFalke commented at 4:45 PM on June 13, 2020: member

review ACK 49236be099c5e8b3cadbc98d5216313e7e1a5a45
fanquake commented at 1:18 AM on June 14, 2020: member

cc @troygiorshev.
jonatack commented at 4:13 AM on June 14, 2020: member

ACK 49236be099c5e8b3cadbc98d5216313e7e1a5a45
troygiorshev commented at 4:43 AM on June 14, 2020: contributor

ACK 49236be. +0.1 on the additional cut_len reformat.
fanquake merged this on Jun 14, 2020
fanquake closed this on Jun 14, 2020
MarcoFalke referenced this in commit 67881de0e3 on Jun 24, 2020
Fabcien referenced this in commit b97f1a9415 on May 13, 2021
random-zebra referenced this in commit bffe509aed on Jun 28, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels