wallet: move BDB specific classes to bdb.{cpp/h} #19290

1. 
   achow101 commented at 0:49 am on June 16, 2020: member

   Moves the BDB specific classes from db.{cpp/h} to bdb.{cpp/h}.

   To do this, SplitWalletFilePath is first made non-static. Then IsWalletLoaded functionality is moved to IsBDBWalletLoaded which is called by IsWalletLoaded. Then the bulk of db.{cpp/h} is moved to a new file bdb.{cpp/h}.

   While doing some moveonly stuff, an additional commit moves the *Cursor and Txn* implementations out of the header file and into the cpp file.

   Part of #18971

2. walletdb: Make SpliWalletFilePath non-static c3538f435a
3. walletdb: Add IsBDBWalletLoaded to look for BDB wallets specifically f6fc5f3849
4. walletdb: move IsWalletLoaded to walletdb.cpp 25a655794a
5. walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp

   Put the implementation in the cpp, not the h file.

   8f033642a8
6. walletdb: Move BDB specific things into bdb.{cpp/h}

   Leave wallet/db.{cpp/h} for generic WalletDatabase stuff. The BDB
   specific stuff goes into bdb.{cpp/h}

   61c16339da
7. fanquake added the label Wallet on Jun 16, 2020
8. 
   DrahtBot commented at 9:48 am on June 16, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19245 ([WIP DONOTMERGE] Replace boost::filesystem with std::filesystem (in c++17) by kiminuo)
   • #19137 (wallettool: Add dump and createfromdump commands by achow101)
   • #19085 (Refactor: clean up PeriodicFlush() by jnewbery)
   • #18907 (walletdb: Don’t remove database transaction logs and instead error by achow101)
   • #18904 (Don’t call lsn_reset in periodic flush by bvbfan)
   • #18618 (gui: Drop RecentRequestsTableModel dependency to WalletModel by promag)
   • #18608 (refactor: Remove CAddressBookData::destdata by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   laanwj commented at 5:02 pm on June 16, 2020: member

   Code review ACK 61c16339da4e80b1320a6296df6d96cd7a84bb4e (you have a misspelling in your first commit message though “SpliWalletFilePath”)
10. 
    promag commented at 5:27 pm on June 16, 2020: member

    Yesterday I was reviewing #18971 and thought about splitting it, and this PR is exactly it.

    Code review ACK 61c16339da4e80b1320a6296df6d96cd7a84bb4e.

    nit, typo in first commit, if you have to push again for some other reason.

11. fanquake requested review from meshcollider on Jun 17, 2020
12. 
    meshcollider commented at 9:18 am on June 17, 2020: contributor

    utACK 61c16339da4e80b1320a6296df6d96cd7a84bb4e
13. meshcollider merged this on Jun 17, 2020
14. meshcollider closed this on Jun 17, 2020

    ---

15. 
    ryanofsky commented at 1:16 pm on June 17, 2020: member

    Code review ACK 61c16339da4e80b1320a6296df6d96cd7a84bb4e
16. MarcoFalke referenced this in commit c7ebab12f9 on Jun 18, 2020
17. Fabcien referenced this in commit de2751c110 on Dec 7, 2020
18. Fabcien referenced this in commit 8343f7b0d3 on Dec 7, 2020
19. Fabcien referenced this in commit 2b7b2154f8 on Dec 7, 2020
20. Fabcien referenced this in commit 7fc87af922 on Dec 7, 2020
21. Fabcien referenced this in commit bde8352066 on Dec 7, 2020
22. DrahtBot locked this on Feb 15, 2022

Contributors
achow101 DrahtBot laanwj promag meshcollider ryanofsky

Labels
Wallet