refactor: Remove unused vars, Add missing includes #19299

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2006-removeUnusedVars changing 5 files +5 −5

MarcoFalke commented at 7:18 PM on June 16, 2020: member

This is required for #19183, but seems like good cleanup that can go in upfront.
Remove unused variables fa09ec83f3

Add missing includes to fix compile errors

fs.cpp:35:17: error: no member named 'strerror' in namespace 'std'
    return std::strerror(errno);
           ~~~~~^
fs.cpp:49:9: error: use of undeclared identifier 'close'
        close(fd);
        ^
2 errors generated.

./interfaces/chain.h:265:55: error: ‘std::function’ has not been declared
     virtual void rpcRunLater(const std::string& name, std::function<void()> fn, int64_t seconds) = 0;
                                                       ^~~

fa193c6b1b

MarcoFalke added the label Refactoring on Jun 16, 2020
DrahtBot commented at 9:44 PM on June 16, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15115 (GUI: Replace send-to-self with dual send+receive entries by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
practicalswift commented at 5:41 AM on June 17, 2020: contributor

ACK fa193c6b1b7da8f72a399bfddb1497655ce1685c -- patch looks correct

Thanks for cleaning up!
hebasto approved
hebasto commented at 6:27 AM on June 17, 2020: member

ACK fa193c6b1b7da8f72a399bfddb1497655ce1685c, I have reviewed the code and it looks OK, I agree it can be merged.
fanquake merged this on Jun 17, 2020
fanquake closed this on Jun 17, 2020
MarcoFalke deleted the branch on Jun 17, 2020
Fabcien referenced this in commit 5e0e8c1d3e on Apr 21, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19183 [WIP DONOTMERGE] Replace boost with C++17 (std::shared_mutex)

refactor: Remove unused vars, Add missing includes #19299

Conflicts