qt: Allow horizontal slider in debugwindow peers tab to autosize display #19327

pull Saibato wants to merge 1 commits into bitcoin:master from Saibato:fix-disp-flags-qt changing 1 files +1 −1

Saibato commented at 8:43 AM on June 19, 2020: contributor

When fiddling around with new node flags other than the usual.

Not all possible node flag strings i.e. UNKNOWN where visible in peers details tab. Since v18.2 fixed size was set to 300 and sliding is thereby limited.

A fix on my old linux cruft and small screen was to set minimumSize width to -1 or 0. Qt the will then autosize the slider to the max string length.

Thereby i had full display of all flags inclusive sliding without to fullscreen the window.

Not sure if this is even an issue for those who can afford big screens or high res macs? Feedback welcome.

qt: Allow horizontal slider in debugwindow peers tab to autosize display

Not all possible node flags where visible since v18.2 with fixed size.
When size width from fixed 300 set to -1 or 0, qt will autosize the slider.

Signed-off-by: saibato <saibato.naga@pm.me>

98e0d29a33

promag commented at 8:50 AM on June 19, 2020: member

@Saibato mind opening this PR in https://github.com/bitcoin-core/gui, which is where GUI changes should be made.
fanquake commented at 9:34 AM on June 19, 2020: member

Moved too: https://github.com/bitcoin-core/gui/pull/6.
fanquake closed this on Jun 19, 2020
Saibato commented at 9:41 AM on June 19, 2020: contributor

Moved too: bitcoin-core/gui#6.

Move Done: BTW: should i file a tracking issue here, since at some point even a big screen can not display all flags at some point with the fixed 300 size?
hebasto commented at 9:58 AM on June 19, 2020: member

Moved too: bitcoin-core/gui#6.

Move Done: BTW: should i file a tracking issue here, since at some point even a big screen can not display all flags at some point with the fixed 300 size?

The GUI-related issues also should filed in https://github.com/bitcoin-core/gui

In this particular case, the understandable pr description with screenshots could be sufficient, imo.
DrahtBot locked this on Feb 15, 2022

Contributors