$< I extract just the basename and then prepend a new location ./test. This is done because $< represents the variable name AND location of the prerequisite here.
test: Change default test logging directory #19385
pull yancyribbens wants to merge 1 commits into bitcoin:master from yancyribbens:unit-log-location changing 1 files +13 −2-
yancyribbens commented at 2:05 pm on June 26, 2020: contributorThis PR changes the default test log location request here: #17224. Instead of using the location of the makefile automatic variable
-
fanquake added the label Tests on Jun 26, 2020
-
MarcoFalke commented at 3:01 pm on June 26, 2020: memberIs the location identical to
abs_top_builddir/src/test? -
yancyribbens force-pushed on Jun 29, 2020
-
yancyribbens commented at 2:58 pm on June 29, 2020: contributor@MarcoFalke yes, it appears so. To make it more clear, I updated the PR and replaced
./with$(abs_builddir). -
laanwj commented at 4:26 pm on June 29, 2020: member
Something I’ve noticed when using out-of-tree builds is that the test logs end up in the source directory, not the build directory. Does this fix that?
Edit: It seems so:
- Before, the test logs ended up in
src/test/*.logandsrc/wallet/test/*.log. - With this PR, they only end up in
build/src/test/*.log. There is no seperate directory for the wallet test logs anymore
I think putting all test logs is fine unless there are overlapping test names?
Concept ACK in any case. Thanks for working on this.
- Before, the test logs ended up in
-
yancyribbens commented at 4:38 pm on June 29, 2020: contributor
@laanwj, yes, this commit fixes that:
0bitcoin$ ./autogen.sh 1bitcoin$ cd build 2bitcoin/build$ ../configure 3bitcoin/build$ make check 4bitcoin/build$ ls src/test/*.logAll .log files are now in
build/src/test/instead ofsrc/test. -
laanwj commented at 4:56 pm on June 29, 2020: memberYep thanks! I’ve edit my post above. My only remark is that the wallet test logs now end up in the same directory, which might or might not be a problem.
-
MarcoFalke closed this on Jun 29, 2020
-
MarcoFalke reopened this on Jun 29, 2020
-
yancyribbens commented at 5:35 pm on June 29, 2020: contributor@laanwj no problem, happy to help. Thanks for mentioning that the wallet tests get tossed into the same directory now. That’s unfortunate I think. Both bitcoin and the wallet tests are added to
BITCOIN_TESTS, and since the commit I made throws away the preceding path, they both end up in the same place. Seems like it would be better to haveBITCOIN_TESTSandBITCOIN_WALLET_TESTShandled separately imo. -
MarcoFalke commented at 9:05 pm on June 29, 2020: member
tested-only ACK 7be5182cd2 did not review the code 🌬
Signature:
0-----BEGIN PGP SIGNED MESSAGE----- 1Hash: SHA512 2 3tested-only ACK 7be5182cd2 did not review the code 🌬 4-----BEGIN PGP SIGNATURE----- 5 6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p 7pUj6nwv/SpacUqHGuJbnt2/Tff21H/4muFKuBGIe4KCXUVxsJHwyBAiNzNOReyDo 81TgPv9/sTFqKclg44C/cCZRH3ajnCQDqK7O4GXTTqa9YEJitTwa0O84avGp6aYY9 9r3GBJqT+ya1jYNkx42mThll/4laMAGIeuAcwfH2blqO45ehvcPMVdqpczV2Zs48l 10JJKIf7/meS1I5BvlyRyqmk+MtCvO21XtzLvpNshklojeHQuNDfYd3/t1aTvZ52rD 11C80IREkSxbcTgNfCvbOx6lXbAHruERG6lCEqIBR9fukZexCgSNw3xPPRv2+EqJwz 12NEDhBobziPaQh9Ne39c7vQlgxOchzYqXXH1AUFMU9uGff8k8edHDoeZmSW/gdIfB 13sXiq6jJxRF5xpc5o1akdrVDw1n+ALHx18sUp96vA9k2XqavRi2dohZEFTFlyH/St 14WMBr97RLDc10jC5hzEOrvhlBK22LazUnqBn04HFkqBzH7ssHkLI3NVyjUwtbCQnF 156sIzZbOS 16=i+yC 17-----END PGP SIGNATURE-----Timestamp of file with hash
ddc033eedeb04a172a4842dbda19a008d539cb63b6c26e9490651ed9a965ed99 - -
MarcoFalke closed this on Jun 29, 2020
-
MarcoFalke commented at 9:06 pm on June 29, 2020: membernot sure why travis is not running on this :man_shrugging:
-
MarcoFalke reopened this on Jun 29, 2020
-
test: Change default test logging directory f8cba0d911
-
yancyribbens force-pushed on Jul 13, 2020
-
yancyribbens commented at 11:34 am on July 13, 2020: contributor@laanwj I updated this PR to preserve the relative path
grep -E -o "(wallet/test/.*\.cpp|test/.*\.cpp)" | $(SED) -e s/\.cpp/.log/\. The bitcoin and wallet tests logs log to their respective directories. -
yancyribbens commented at 11:37 am on July 13, 2020: contributorI also cleaned up the makefile rule so it’s more readable hopefully by using some line wraps.
-
yancyribbens commented at 11:40 am on July 13, 2020: contributor@MarcoFalke not sure either why Travis is ignoring this PR. Would it help to close this one and open another? I don’t see any conflicts that would cause Travis to not run.
-
MarcoFalke commented at 4:48 pm on July 13, 2020: memberConcept re-ACK, happy to test
-
laanwj added the label Build system on Jul 15, 2020
-
theStack commented at 9:26 pm on September 8, 2020: memberConcept ACK
-
elmarsan commented at 5:11 pm on September 7, 2021: none
Hello, what is the state of this pull request? Is the problem with Travis solved?
Thanks
-
niVelion commented at 11:40 am on January 14, 2022: none
@MarcoFalke not sure either why Travis is ignoring this PR. Would it help to close this one and open another? I don’t see any conflicts that would cause Travis to not run.
Bump @MarcoFalke for the above comment. I too wonder if closing this PR might help, though would first try re-opening it rather than creating another.
-
MarcoFalke commented at 11:51 am on January 14, 2022: memberI think it is fine to test locally (someone needs to do that anyway)
-
MarcoFalke commented at 11:59 am on March 25, 2022: member
In tree build:
- log files have the
cpp.infix removed
0diff --git a/tmp/1 b/tmp/2 1index 0e4015b93..88a87988a 100644 2--- a/tmp/1 3+++ b/tmp/2 4@@ -1,8 +1,8 @@ 5-diff --git a/tmp/a b/tmp/b 6-index 6a6dab4b8..e165f1bf1 100644 7---- a/tmp/a 8-+++ b/tmp/b 9-@@ -542,6 +542,8 @@ 10+diff --git a/tmp/c b/tmp/d 11+index 1974a3640..3e621ff71 100644 12+--- a/tmp/c 13++++ b/tmp/d 14+@@ -543,6 +543,8 @@ 15 | | `-- extract_strings_qt.py 16 | |-- rpcauth 17 | | |-- README.md 18@@ -11,7 +11,7 @@ index 6a6dab4b8..e165f1bf1 100644 19 | | `-- rpcauth.py 20 | |-- setup.nsi 21 | `-- setup.nsi.in 22-@@ -1318,6 +1320,8 @@ 23+@@ -1320,6 +1322,8 @@ 24 | | | |-- test.cpp 25 | | | `-- util.h 26 | | |-- test 27@@ -20,7 +20,7 @@ index 6a6dab4b8..e165f1bf1 100644 28 | | `-- tests 29 | | `-- pyminisketch.py 30 | |-- net.cpp 31-@@ -1944,6 +1948,9 @@ 32+@@ -1947,6 +1951,9 @@ 33 | | | `-- lax_der_privatekey_parsing.h 34 | | |-- doc 35 | | | `-- safegcd_implementation.md 36@@ -30,7 +30,7 @@ index 6a6dab4b8..e165f1bf1 100644 37 | | |-- include 38 | | | |-- secp256k1.h 39 | | | |-- secp256k1_ecdh.h 40-@@ -1962,93 +1969,99 @@ 41+@@ -1965,94 +1972,100 @@ 42 | | | |-- prove_group_implementations.sage 43 | | | |-- secp256k1_params.sage 44 | | | `-- weierstrass_prover.sage 45@@ -73,6 +73,7 @@ index 6a6dab4b8..e165f1bf1 100644 46 -| | |-- hash_impl.h 47 -| | |-- libsecp256k1-config.h 48 -| | |-- libsecp256k1-config.h.in 49+-| | |-- libsecp256k1-config.h.in~ 50 -| | |-- libsecp256k1_la-secp256k1.lo 51 -| | |-- libsecp256k1_la-secp256k1.o 52 -| | |-- modinv32.h 53@@ -161,6 +162,7 @@ index 6a6dab4b8..e165f1bf1 100644 54 +| | | |-- hash_impl.h 55 +| | | |-- libsecp256k1-config.h 56 +| | | |-- libsecp256k1-config.h.in 57++| | | |-- libsecp256k1-config.h.in~ 58 +| | | |-- libsecp256k1_la-secp256k1.lo 59 +| | | |-- libsecp256k1_la-secp256k1.o 60 +| | | |-- modinv32.h 61@@ -217,219 +219,219 @@ index 6a6dab4b8..e165f1bf1 100644 62 | |-- serialize.h 63 | |-- shutdown.cpp 64 | |-- shutdown.h 65-@@ -2075,28 +2088,51 @@ 66+@@ -2079,28 +2092,51 @@ 67 | | |-- Makefile 68 | | |-- README.md 69 | | |-- addrman_tests.cpp 70-+| | |-- addrman_tests.cpp.log 71++| | |-- addrman_tests.log 72 | | |-- allocator_tests.cpp 73-+| | |-- allocator_tests.cpp.log 74++| | |-- allocator_tests.log 75 | | |-- amount_tests.cpp 76-+| | |-- amount_tests.cpp.log 77++| | |-- amount_tests.log 78 | | |-- arith_uint256_tests.cpp 79-+| | |-- arith_uint256_tests.cpp.log 80++| | |-- arith_uint256_tests.log 81 | | |-- banman_tests.cpp 82-+| | |-- banman_tests.cpp.log 83++| | |-- banman_tests.log 84 | | |-- base32_tests.cpp 85-+| | |-- base32_tests.cpp.log 86++| | |-- base32_tests.log 87 | | |-- base58_tests.cpp 88-+| | |-- base58_tests.cpp.log 89++| | |-- base58_tests.log 90 | | |-- base64_tests.cpp 91-+| | |-- base64_tests.cpp.log 92++| | |-- base64_tests.log 93 | | |-- bech32_tests.cpp 94-+| | |-- bech32_tests.cpp.log 95++| | |-- bech32_tests.log 96 | | |-- bip32_tests.cpp 97-+| | |-- bip32_tests.cpp.log 98++| | |-- bip32_tests.log 99 | | |-- blockchain_tests.cpp 100-+| | |-- blockchain_tests.cpp.log 101++| | |-- blockchain_tests.log 102 | | |-- blockencodings_tests.cpp 103-+| | |-- blockencodings_tests.cpp.log 104++| | |-- blockencodings_tests.log 105 | | |-- blockfilter_index_tests.cpp 106-+| | |-- blockfilter_index_tests.cpp.log 107++| | |-- blockfilter_index_tests.log 108 | | |-- blockfilter_tests.cpp 109-+| | |-- blockfilter_tests.cpp.log 110++| | |-- blockfilter_tests.log 111 | | |-- bloom_tests.cpp 112-+| | |-- bloom_tests.cpp.log 113++| | |-- bloom_tests.log 114 | | |-- bswap_tests.cpp 115-+| | |-- bswap_tests.cpp.log 116++| | |-- bswap_tests.log 117 | | |-- checkqueue_tests.cpp 118-+| | |-- checkqueue_tests.cpp.log 119++| | |-- checkqueue_tests.log 120 | | |-- coins_tests.cpp 121-+| | |-- coins_tests.cpp.log 122++| | |-- coins_tests.log 123 | | |-- coinstatsindex_tests.cpp 124-+| | |-- coinstatsindex_tests.cpp.log 125++| | |-- coinstatsindex_tests.log 126 | | |-- compilerbug_tests.cpp 127-+| | |-- compilerbug_tests.cpp.log 128++| | |-- compilerbug_tests.log 129 | | |-- compress_tests.cpp 130-+| | |-- compress_tests.cpp.log 131++| | |-- compress_tests.log 132 | | |-- crypto_tests.cpp 133-+| | |-- crypto_tests.cpp.log 134++| | |-- crypto_tests.log 135 | | |-- cuckoocache_tests.cpp 136-+| | |-- cuckoocache_tests.cpp.log 137++| | |-- cuckoocache_tests.log 138 | | |-- data 139 | | | |-- README.md 140 | | | |-- asmap.raw 141-@@ -2120,10 +2156,15 @@ 142+@@ -2124,10 +2160,15 @@ 143 | | | |-- tx_valid.json 144 | | | `-- tx_valid.json.h 145 | | |-- dbwrapper_tests.cpp 146-+| | |-- dbwrapper_tests.cpp.log 147++| | |-- dbwrapper_tests.log 148 | | |-- denialofservice_tests.cpp 149-+| | |-- denialofservice_tests.cpp.log 150++| | |-- denialofservice_tests.log 151 | | |-- descriptor_tests.cpp 152-+| | |-- descriptor_tests.cpp.log 153++| | |-- descriptor_tests.log 154 | | |-- flatfile_tests.cpp 155-+| | |-- flatfile_tests.cpp.log 156++| | |-- flatfile_tests.log 157 | | |-- fs_tests.cpp 158-+| | |-- fs_tests.cpp.log 159++| | |-- fs_tests.log 160 | | |-- fuzz 161 | | | |-- FuzzedDataProvider.h 162 | | | |-- addition_overflow.cpp 163-@@ -2344,50 +2385,93 @@ 164+@@ -2348,50 +2389,93 @@ 165 | | | |-- validation_load_mempool.cpp 166 | | | `-- versionbits.cpp 167 | | |-- getarg_tests.cpp 168-+| | |-- getarg_tests.cpp.log 169++| | |-- getarg_tests.log 170 | | |-- hash_tests.cpp 171-+| | |-- hash_tests.cpp.log 172++| | |-- hash_tests.log 173 | | |-- i2p_tests.cpp 174-+| | |-- i2p_tests.cpp.log 175++| | |-- i2p_tests.log 176 | | |-- interfaces_tests.cpp 177-+| | |-- interfaces_tests.cpp.log 178++| | |-- interfaces_tests.log 179 | | |-- key_io_tests.cpp 180-+| | |-- key_io_tests.cpp.log 181++| | |-- key_io_tests.log 182 | | |-- key_tests.cpp 183-+| | |-- key_tests.cpp.log 184++| | |-- key_tests.log 185 | | |-- logging_tests.cpp 186-+| | |-- logging_tests.cpp.log 187++| | |-- logging_tests.log 188 | | |-- main.cpp 189 | | |-- mempool_tests.cpp 190-+| | |-- mempool_tests.cpp.log 191++| | |-- mempool_tests.log 192 | | |-- merkle_tests.cpp 193-+| | |-- merkle_tests.cpp.log 194++| | |-- merkle_tests.log 195 | | |-- merkleblock_tests.cpp 196-+| | |-- merkleblock_tests.cpp.log 197++| | |-- merkleblock_tests.log 198 | | |-- miner_tests.cpp 199-+| | |-- miner_tests.cpp.log 200++| | |-- miner_tests.log 201 | | |-- minisketch_tests.cpp 202-+| | |-- minisketch_tests.cpp.log 203++| | |-- minisketch_tests.log 204 | | |-- multisig_tests.cpp 205-+| | |-- multisig_tests.cpp.log 206++| | |-- multisig_tests.log 207 | | |-- net_peer_eviction_tests.cpp 208-+| | |-- net_peer_eviction_tests.cpp.log 209++| | |-- net_peer_eviction_tests.log 210 | | |-- net_tests.cpp 211-+| | |-- net_tests.cpp.log 212++| | |-- net_tests.log 213 | | |-- netbase_tests.cpp 214-+| | |-- netbase_tests.cpp.log 215++| | |-- netbase_tests.log 216 | | |-- pmt_tests.cpp 217-+| | |-- pmt_tests.cpp.log 218++| | |-- pmt_tests.log 219 | | |-- policy_fee_tests.cpp 220-+| | |-- policy_fee_tests.cpp.log 221++| | |-- policy_fee_tests.log 222 | | |-- policyestimator_tests.cpp 223-+| | |-- policyestimator_tests.cpp.log 224++| | |-- policyestimator_tests.log 225 | | |-- pow_tests.cpp 226-+| | |-- pow_tests.cpp.log 227++| | |-- pow_tests.log 228 | | |-- prevector_tests.cpp 229-+| | |-- prevector_tests.cpp.log 230++| | |-- prevector_tests.log 231 | | |-- raii_event_tests.cpp 232-+| | |-- raii_event_tests.cpp.log 233++| | |-- raii_event_tests.log 234 | | |-- random_tests.cpp 235-+| | |-- random_tests.cpp.log 236++| | |-- random_tests.log 237 | | |-- reverselock_tests.cpp 238-+| | |-- reverselock_tests.cpp.log 239++| | |-- reverselock_tests.log 240 | | |-- rpc_tests.cpp 241-+| | |-- rpc_tests.cpp.log 242++| | |-- rpc_tests.log 243 | | |-- sanity_tests.cpp 244-+| | |-- sanity_tests.cpp.log 245++| | |-- sanity_tests.log 246 | | |-- scheduler_tests.cpp 247-+| | |-- scheduler_tests.cpp.log - log files have the
-
MarcoFalke commented at 12:13 pm on March 25, 2022: member
Out-of tree build:
- (unrelated) Looks like
../share/rpcauth/will initialize a pycache folder. This can be fixed in a follow-up - log files have the
cpp.infix removed - log files are moved out-of tree
0diff --git a/tmp/1 b/tmp/2 1index 8546e6a08..e7e05a939 100644 2--- a/tmp/1 3+++ b/tmp/2 4@@ -1,7 +1,7 @@ 5-diff --git a/tmp/a b/tmp/b 6-index a6e6e038b..fa13e37e7 100644 7---- a/tmp/a 8-+++ b/tmp/b 9+diff --git a/tmp/c b/tmp/d 10+index a6e6e038b..968ccb33d 100644 11+--- a/tmp/c 12++++ b/tmp/d 13 @@ -357,7 +357,9 @@ 14 | | | | | `-- libminisketch_clmul_a-clmul_8bytes.o 15 | | | | |-- libminisketch_a-minisketch.o 16@@ -13,7 +13,7 @@ index a6e6e038b..fa13e37e7 100644 17 | | |-- node 18 | | | |-- libbitcoin_node_a-blockstorage.o 19 | | | |-- libbitcoin_node_a-caches.o 20-@@ -426,14 +428,23 @@ 21+@@ -426,20 +428,52 @@ 22 | | | |-- Makefile 23 | | | |-- config.log 24 | | | |-- config.status 25@@ -42,15 +42,146 @@ index a6e6e038b..fa13e37e7 100644 26 | | |-- support 27 | | | |-- libbitcoin_util_a-cleanse.o 28 | | | |-- libbitcoin_util_a-lockedpool.o 29-@@ -662,6 +673,7 @@ 30- | | | |-- libtest_util_a-transaction_utils.o 31- | | | |-- libtest_util_a-validation.o 32- | | | `-- libtest_util_a-wallet.o 33+ | | | |-- libbitcoinconsensus_la-cleanse.lo 34+ | | | `-- libbitcoinconsensus_la-cleanse.o 35+ | | |-- test 36++| | | |-- addrman_tests.log 37++| | | |-- allocator_tests.log 38++| | | |-- amount_tests.log 39++| | | |-- arith_uint256_tests.log 40++| | | |-- banman_tests.log 41++| | | |-- base32_tests.log 42++| | | |-- base58_tests.log 43++| | | |-- base64_tests.log 44++| | | |-- bech32_tests.log 45++| | | |-- bip32_tests.log 46++| | | |-- blockchain_tests.log 47++| | | |-- blockencodings_tests.log 48++| | | |-- blockfilter_index_tests.log 49++| | | |-- blockfilter_tests.log 50++| | | |-- bloom_tests.log 51++| | | |-- bswap_tests.log 52++| | | |-- checkqueue_tests.log 53++| | | |-- coins_tests.log 54++| | | |-- coinstatsindex_tests.log 55++| | | |-- compilerbug_tests.log 56++| | | |-- compress_tests.log 57++| | | |-- crypto_tests.log 58++| | | |-- cuckoocache_tests.log 59+ | | | |-- data 60+ | | | | |-- asmap.raw.h 61+ | | | | |-- base58_encode_decode.json.h 62+@@ -451,6 +485,11 @@ 63+ | | | | |-- sighash.json.h 64+ | | | | |-- tx_invalid.json.h 65+ | | | | `-- tx_valid.json.h 66++| | | |-- dbwrapper_tests.log 67++| | | |-- denialofservice_tests.log 68++| | | |-- descriptor_tests.log 69++| | | |-- flatfile_tests.log 70++| | | |-- fs_tests.log 71+ | | | |-- fuzz 72+ | | | | |-- fuzz 73+ | | | | |-- fuzz-addition_overflow.o 74+@@ -560,6 +599,49 @@ 75+ | | | | |-- fuzz-versionbits.o 76+ | | | | |-- libtest_fuzz_a-fuzz.o 77+ | | | | `-- libtest_fuzz_a-util.o 78++| | | |-- getarg_tests.log 79++| | | |-- hash_tests.log 80++| | | |-- i2p_tests.log 81++| | | |-- interfaces_tests.log 82++| | | |-- key_io_tests.log 83++| | | |-- key_tests.log 84++| | | |-- logging_tests.log 85++| | | |-- mempool_tests.log 86++| | | |-- merkle_tests.log 87++| | | |-- merkleblock_tests.log 88++| | | |-- miner_tests.log 89++| | | |-- minisketch_tests.log 90++| | | |-- multisig_tests.log 91++| | | |-- net_peer_eviction_tests.log 92++| | | |-- net_tests.log 93++| | | |-- netbase_tests.log 94++| | | |-- pmt_tests.log 95++| | | |-- policy_fee_tests.log 96++| | | |-- policyestimator_tests.log 97++| | | |-- pow_tests.log 98++| | | |-- prevector_tests.log 99++| | | |-- raii_event_tests.log 100++| | | |-- random_tests.log 101++| | | |-- reverselock_tests.log 102++| | | |-- rpc_tests.log 103++| | | |-- sanity_tests.log 104++| | | |-- scheduler_tests.log 105++| | | |-- script_p2sh_tests.log 106++| | | |-- script_parse_tests.log 107++| | | |-- script_segwit_tests.log 108++| | | |-- script_standard_tests.log 109++| | | |-- script_tests.log 110++| | | |-- scriptnum_tests.log 111++| | | |-- serfloat_tests.log 112++| | | |-- serialize_tests.log 113++| | | |-- settings_tests.log 114++| | | |-- sighash_tests.log 115++| | | |-- sigopcount_tests.log 116++| | | |-- skiplist_tests.log 117++| | | |-- sock_tests.log 118++| | | |-- streams_tests.log 119++| | | |-- sync_tests.log 120++| | | |-- system_tests.log 121+ | | | |-- test_bitcoin 122+ | | | |-- test_bitcoin-addrman_tests.o 123+ | | | |-- test_bitcoin-allocator_tests.o 124+@@ -651,17 +733,36 @@ 125+ | | | |-- test_bitcoin-validation_tests.o 126+ | | | |-- test_bitcoin-validationinterface_tests.o 127+ | | | |-- test_bitcoin-versionbits_tests.o 128+-| | | `-- util 129+-| | | |-- libtest_util_a-blockfilter.o 130+-| | | |-- libtest_util_a-logging.o 131+-| | | |-- libtest_util_a-mining.o 132+-| | | |-- libtest_util_a-net.o 133+-| | | |-- libtest_util_a-script.o 134+-| | | |-- libtest_util_a-setup_common.o 135+-| | | |-- libtest_util_a-str.o 136+-| | | |-- libtest_util_a-transaction_utils.o 137+-| | | |-- libtest_util_a-validation.o 138+-| | | `-- libtest_util_a-wallet.o 139++| | | |-- timedata_tests.log 140++| | | |-- torcontrol_tests.log 141++| | | |-- transaction_tests.log 142++| | | |-- txindex_tests.log 143++| | | |-- txpackage_tests.log 144++| | | |-- txrequest_tests.log 145++| | | |-- txvalidation_tests.log 146++| | | |-- txvalidationcache_tests.log 147++| | | |-- uint256_tests.log 148++| | | |-- util 149++| | | | |-- libtest_util_a-blockfilter.o 150++| | | | |-- libtest_util_a-logging.o 151++| | | | |-- libtest_util_a-mining.o 152++| | | | |-- libtest_util_a-net.o 153++| | | | |-- libtest_util_a-script.o 154++| | | | |-- libtest_util_a-setup_common.o 155++| | | | |-- libtest_util_a-str.o 156++| | | | |-- libtest_util_a-transaction_utils.o 157++| | | | |-- libtest_util_a-validation.o 158++| | | | `-- libtest_util_a-wallet.o 159++| | | |-- util_tests.log 160++| | | |-- util_threadnames_tests.log 161++| | | |-- validation_block_tests.log 162++| | | |-- validation_chainstate_tests.log 163++| | | |-- validation_chainstatemanager_tests.log 164++| | | |-- validation_flush_tests.log 165++| | | |-- validation_tests.log 166++| | | |-- validationinterface_tests.log 167++| | | `-- versionbits_tests.log 168 +| | |-- test-suite.log 169 | | |-- univalue 170 | | | |-- lib 171 | | | | |-- libunivalue_la-univalue.lo 172-@@ -675,10 +687,16 @@ 173+@@ -675,10 +776,16 @@ 174 | | | `-- test 175 | | | |-- no_nul 176 | | | |-- no_nul-no_nul.o 177@@ -68,7 +199,7 @@ index a6e6e038b..fa13e37e7 100644 178 | | |-- util 179 | | | |-- libbitcoin_consensus_a-strencodings.o 180 | | | |-- libbitcoin_util_a-asmap.o 181-@@ -1208,6 +1226,8 @@ 182+@@ -1208,6 +1315,8 @@ 183 | | `-- extract_strings_qt.py 184 | |-- rpcauth 185 | | |-- README.md 186@@ -77,211 +208,6 @@ index a6e6e038b..fa13e37e7 100644 187 | | `-- rpcauth.py 188 | `-- setup.nsi.in 189 |-- src 190-@@ -2405,28 +2425,51 @@ 191- | | |-- Makefile 192- | | |-- README.md 193- | | |-- addrman_tests.cpp 194-+| | |-- addrman_tests.cpp.log 195- | | |-- allocator_tests.cpp 196-+| | |-- allocator_tests.cpp.log 197- | | |-- amount_tests.cpp 198-+| | |-- amount_tests.cpp.log 199- | | |-- arith_uint256_tests.cpp 200-+| | |-- arith_uint256_tests.cpp.log 201- | | |-- banman_tests.cpp 202-+| | |-- banman_tests.cpp.log 203- | | |-- base32_tests.cpp 204-+| | |-- base32_tests.cpp.log 205- | | |-- base58_tests.cpp 206-+| | |-- base58_tests.cpp.log 207- | | |-- base64_tests.cpp 208-+| | |-- base64_tests.cpp.log 209- | | |-- bech32_tests.cpp 210-+| | |-- bech32_tests.cpp.log 211- | | |-- bip32_tests.cpp 212-+| | |-- bip32_tests.cpp.log 213- | | |-- blockchain_tests.cpp 214-+| | |-- blockchain_tests.cpp.log 215- | | |-- blockencodings_tests.cpp 216-+| | |-- blockencodings_tests.cpp.log 217- | | |-- blockfilter_index_tests.cpp 218-+| | |-- blockfilter_index_tests.cpp.log 219- | | |-- blockfilter_tests.cpp 220-+| | |-- blockfilter_tests.cpp.log 221- | | |-- bloom_tests.cpp 222-+| | |-- bloom_tests.cpp.log 223- | | - (unrelated) Looks like
-
MarcoFalke merged this on Mar 25, 2022
-
MarcoFalke closed this on Mar 25, 2022
-
in src/Makefile.test.include:1183 in f8cba0d911
1180+ cat $< | \ 1181+ grep -E "(BOOST_FIXTURE_TEST_SUITE\\(|BOOST_AUTO_TEST_SUITE\\()" | \ 1182+ cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1\ 1183+ )" -- DEBUG_LOG_OUT > $(abs_builddir)/$$(\ 1184+ echo $< | grep -E -o "(wallet/test/.*\.cpp|test/.*\.cpp)" | $(SED) -e s/\.cpp/.log/\ 1185+ ) 2>&1 || (cat $<.log && false)
hebasto commented at 7:55 am on March 30, 2022: memberUnfortunately, this is broken.
With the following diff:
0--- a/src/test/addrman_tests.cpp 1+++ b/src/test/addrman_tests.cpp 2@@ -67,7 +67,7 @@ BOOST_AUTO_TEST_CASE(addrman_simple) 3 CNetAddr source = ResolveIP("252.2.2.2"); 4 5 // Test: Does Addrman respond correctly when empty. 6- BOOST_CHECK_EQUAL(addrman->size(), 0U); 7+ BOOST_CHECK_EQUAL(addrman->size(), 1U); 8 auto addr_null = addrman->Select().first; 9 BOOST_CHECK_EQUAL(addr_null.ToString(), "[::]:0"); 10one has
0$ make check 1... 2Running tests: addrman_tests from test/addrman_tests.cpp 3cat: test/addrman_tests.cpp.log: No such file or directory 4...MarcoFalke commented at 8:14 am on March 30, 2022: memberThe second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.hebasto commented at 8:32 am on March 30, 2022: memberThe second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.
Ok, let me look into it.
hebasto commented at 10:23 am on March 30, 2022: memberThe second commit of https://github.com/bitcoin/bitcoin/pull/16228/commits claims to fix this.
A fix suggested in #24715.
MarcoFalke referenced this in commit d2b4355c58 on Mar 31, 2022sidhujag referenced this in commit d1042c8870 on Apr 2, 2022sidhujag referenced this in commit 5e7cf64a5c on Apr 3, 2022achow101 referenced this in commit 243d7bde78 on Aug 11, 2022DrahtBot locked this on Mar 30, 2023
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 03:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me