build: Remove unused RES_IMAGES #19394

pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:bitcoin-remove-res-images changing 1 files +2 −4
  1. Bushstar commented at 10:44 AM on June 27, 2020: contributor

    Remove RES_IMAGES. Seems to be unused since 2015 in the commit below.

    https://github.com/bitcoin/bitcoin/commit/98c222b5aa94543fce683b989356b0d8ad1f1d22#diff-9a4f3a253de77bf90b107bdf5283ebc3R317

    The src/qt/res/images to which it was used with is no longer present either.

  2. DrahtBot added the label Build system on Jun 27, 2020
  3. fanquake renamed this:
    [build] Remove unused RES_IMAGES
    build: Remove unused RES_IMAGES
    on Jun 29, 2020
  4. fanquake commented at 4:35 AM on June 29, 2020: member
  5. [build] Remove unused RES_IMAGES 53361ddc75
  6. Bushstar force-pushed on Jun 29, 2020
  7. Bushstar commented at 4:50 AM on June 29, 2020: contributor

    @fanquake PR updated, thanks.

  8. hebasto commented at 1:24 PM on June 29, 2020: member

    Concept ACK.

  9. hebasto approved
  10. hebasto commented at 1:36 PM on June 29, 2020: member

    ACK 53361ddc7591f35df36cc71d11c24f826f209e11, tested on Linux Mint 20 (x86_64).

  11. MarcoFalke merged this on Jun 29, 2020
  12. MarcoFalke closed this on Jun 29, 2020

  13. thijstriemstra commented at 2:42 PM on June 29, 2020: none

    What about $(RES_MOVIES)? Are there really video clips included..

  14. hebasto commented at 2:46 PM on June 29, 2020: member
  15. MarcoFalke commented at 2:46 PM on June 29, 2020: member

    RES_ANIMATION would be a better name for the spinner, I guess

  16. thijstriemstra commented at 2:47 PM on June 29, 2020: none

    Renaming the directory would also help I guess: $(srcdir)/qt/res/movies What does 'res' even mean, resources? Maybe also use resources instead of res?

  17. Bushstar commented at 3:00 PM on June 29, 2020: contributor

    Created a PR here to rename movies to animation.

    #19414

    Movies has always seemed like an odd term for the spinner animation.

  18. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me