http: Detect remote disconnect #19434

1. 
   promag commented at 1:20 am on July 3, 2020: member

   Builds on #19420, review last commit only.
2. fanquake added the label RPC/REST/ZMQ on Jul 3, 2020
3. 
   promag commented at 1:24 am on July 3, 2020: member

   This is a requirement in case we want to support RPC interruption due to connection close. For instance, currently interrupting the command bitcoin-cli -regtest waitfornewblock doesn’t interrupt the server handling.

   This is also relevant for long calls, especially scantxoutset.

4. promag force-pushed on Jul 5, 2020
5. 
   DrahtBot commented at 10:39 pm on July 5, 2020: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19420 by promag

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. promag closed this on Jul 16, 2020

   ---

7. 
   promag commented at 12:23 pm on July 16, 2020: member

   Re-run CI.
8. promag reopened this on Jul 16, 2020

   ---

9. http: Release work queue after event base finish

   This fixes a race between http_request_cb and StopHTTPServer where
   the work queue is used after release.

   f4fa4255b4
10. http: Track active requests and wait for last to finish 2c3cd7bdaa
11. http: Relese server before waiting for event base loop exit 6ea65ee550
12. http: Detect remote disconnect e64264814d
13. wip 578fed1f5d
14. in test/functional/mining_getblocktemplate_longpoll.py:27 in 5ea6e50fc4 outdated

    21@@ -22,7 +22,10 @@ def __init__(self, node):
    22         self.node = get_rpc_proxy(node.url, 1, timeout=600, coveragedir=node.coverage_dir)
    23 
    24     def run(self):
    25-        self.node.getblocktemplate({'longpollid': self.longpollid, 'rules': ['segwit']})
    26+        try:
    27+            self.node.getblocktemplate({'longpollid': self.longpollid, 'rules': ['segwit']})
    28+        except:
    

    ---

    ---

    

    luke-jr commented at 11:48 pm on July 23, 2020:

    Why is this test breaking?
15. promag force-pushed on Aug 16, 2020
16. DrahtBot added the label Needs rebase on Dec 13, 2021
17. 
    DrahtBot commented at 11:19 pm on December 13, 2021: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

18. 
    DrahtBot commented at 1:07 pm on March 21, 2022: contributor

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
19. 
    maflcko commented at 1:39 pm on March 21, 2022: member

    Looks like this might be waiting on #19420
20. 
    promag commented at 1:43 pm on March 21, 2022: member

    @MarcoFalke 👍
21. 
    fanquake commented at 11:08 am on December 6, 2022: member

    Given that #19420 (base PR) has now been closed, going to close this for now as well. If the base PR is reopened, we could reopen this PR too.
22. fanquake closed this on Dec 6, 2022

    ---

23. achow101 referenced this in commit 86bacd75e7 on Mar 7, 2023
24. sidhujag referenced this in commit 61edeffbd5 on Mar 7, 2023
25. fanquake referenced this in commit db7b5dfcc5 on Oct 4, 2023
26. Frank-GER referenced this in commit b0fea09705 on Oct 13, 2023
27. bitcoin locked this on Dec 6, 2023

Contributors
promag DrahtBot luke-jr maflcko fanquake

Labels
RPC/REST/ZMQ Needs rebase