refactor: Rename signal TransactionRemovedFromMempool to better describe behavior #19520

1. 
   instagibbs commented at 5:48 pm on July 14, 2020: member
2. 
   DrahtBot commented at 7:00 pm on July 14, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19572 (ZMQ: Create “sequence” notifier, enabling client-side mempool tracking by instagibbs)
   • #18354 (Use shared pointers only in validation interface by bvbfan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Mempool on Jul 14, 2020
4. DrahtBot added the label Validation on Jul 14, 2020
5. 
   MarcoFalke commented at 7:10 am on July 15, 2020: member

   why not as a scripted diff?
6. instagibbs force-pushed on Jul 15, 2020
7. 
   instagibbs commented at 2:02 pm on July 15, 2020: member

   Because I had to learn the tool :smirk:
8. scripted-diff: Rename signal TransactionRemovedFromMempool to better describe behavior

   -BEGIN VERIFY SCRIPT-
   git grep -l 'TransactionRemovedFromMempool' | xargs sed -i 's/TransactionRemovedFromMempool/TransactionRemovedFromMempoolNotConfirmed/g'
   -END VERIFY SCRIPT-

   bf36bc9369
9. instagibbs force-pushed on Jul 15, 2020
10. fanquake renamed this:
    Rename signal TransactionRemovedFromMempool to better describe behavior
    refactor: Rename signal TransactionRemovedFromMempool to better describe behavior
    on Jul 28, 2020
11. 
    fanquake commented at 8:00 am on July 28, 2020: member

    Because I had to learn the tool 😏

    Looks like you didn’t do a very good job 😏

     0Running script for: bf36bc9369a86198c0f24871dadc168f9db6fa7c
     1
     2git grep -l 'TransactionRemovedFromMempool' | xargs sed -i 's/TransactionRemovedFromMempool/TransactionRemovedFromMempoolNotConfirmed/g'
     3
     4diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
     5
     6index 8eec00993..4d67cac72 100644
     7
     8--- a/src/wallet/wallet.cpp
     9
    10+++ b/src/wallet/wallet.cpp
    11
    12@@ -1829,7 +1829,7 @@ bool CWalletTx::SubmitMemoryPoolAndRelay(std::string& err_string, bool relay)
    13
    14     //
    15
    16     // Irrespective of the failure reason, un-marking fInMempool
    17
    18     // out-of-order is incorrect - it should be unmarked when
    19
    20-    // TransactionRemovedFromMempool fires.
    21
    22+    // TransactionRemovedFromMempoolNotConfirmed fires.
    23
    24     bool ret = pwallet->chain().broadcastTransaction(tx, pwallet->m_default_max_tx_fee, relay, err_string);
    25
    26     fInMempool |= ret;
    27
    28     return ret;
    29
    30Failed
    

    Also please add a PR description.

12. 
    instagibbs commented at 1:24 pm on July 29, 2020: member

    I’ll learn the tool in a new life I guess
13. instagibbs closed this on Jul 29, 2020

    ---

14. DrahtBot locked this on Feb 15, 2022

Contributors
instagibbs DrahtBot MarcoFalke fanquake

Labels
Validation Mempool