qt, build: Fix QFileDialog for static builds #19536

1. 
   hebasto commented at 5:33 pm on July 16, 2020: member

   This change partially reverts 248e22bbc0d7bc40ae3584d53a18507c46b0e553 (#16386) and makes QFileDialogs work again for static builds.

   Fixes https://github.com/bitcoin-core/gui/issues/32.

2. qt: Fix QFileDialog for static builds

   This change partially reverts 248e22bbc0d7bc40ae3584d53a18507c46b0e553.

   6457361e90
3. 
   hebasto commented at 5:48 pm on July 16, 2020: member

   @MarcoFalke @fanquake label for backporting?
4. DrahtBot added the label Build system on Jul 16, 2020
5. theuni approved
6. 
   theuni commented at 7:18 pm on July 16, 2020: member

   ACK 6457361e90c0cf704d086c51d75f51dbdfd374d7
7. MarcoFalke added the label Needs backport (0.20) on Jul 17, 2020
8. MarcoFalke added this to the milestone 0.20.1 on Jul 17, 2020
9. MarcoFalke added the label Needs gitian build on Jul 17, 2020
10. MarcoFalke added the label Needs Guix build on Jul 17, 2020
11. 
    Sjors commented at 6:18 am on July 17, 2020: member

    Concept ACK. It might make sense to maintain a list of QT components we do use, or least mention somewhere that filesystemwatcher really shouldn’t be removed.

    I assume this can be tested with the Load PSBT menu as well, once the Gitian build is ready.

12. 
    fanquake commented at 6:24 am on July 17, 2020: member

    ACK 6457361e90c0cf704d086c51d75f51dbdfd374d7. Although it would be good to know exactly why this fixes the issue. At this stage I also don’t think this should be a blocker for 0.20.1.

    After discussing with @hebasto I gather it’s restricted to Linux-only, and is somehow related to the xcb QPA plugin. I had a quick look through the qtbase 5.9.8 source, and my assumption is there maybe a dependency like QFileDialog -> QFileSystemModel -> QFileSystemWatcher which may not be completely #ifndef QT_NO_FILESYSTEMWATCHER’d out, or which is not possible to break, as it seems that QFileSystemModel may try and use QFileSystemWatcher for caching.

13. fanquake merged this on Jul 17, 2020
14. fanquake closed this on Jul 17, 2020

    ---

15. MarcoFalke removed the label Needs Guix build on Jul 17, 2020
16. MarcoFalke removed the label Needs gitian build on Jul 17, 2020
17. 
    hebasto commented at 9:23 am on July 17, 2020: member

    @Sjors

    Concept ACK. It might make sense to maintain a list of QT components we do use, or least mention somewhere that filesystemwatcher really shouldn’t be removed.

    Nice suggestion!

    I assume this can be tested with the Load PSBT menu as well, once the Gitian build is ready.

    For testing builds with depends could be used as well.

18. 
    hebasto commented at 9:25 am on July 17, 2020: member

    @MarcoFalke @fanquake label for backporting?

    As the bug was introduced in v0.19 maybe also label this PR with “Needs backport (0.19)” ?

19. hebasto deleted the branch on Jul 17, 2020
20. laanwj referenced this in commit 8b40937493 on Jul 17, 2020
21. MarcoFalke removed the label Needs backport (0.20) on Jul 17, 2020
22. MarcoFalke added the label Needs backport (0.19) on Jul 17, 2020
23. MarcoFalke removed this from the milestone 0.20.1 on Jul 17, 2020
24. MarcoFalke added this to the milestone 0.19.2 on Jul 17, 2020
25. 
    alexstrbonn commented at 4:13 pm on July 19, 2020: none

    @MarcoFalke MarcoFalke Will this be only fixed once 0.20.1 will be available? Thanks!
26. 
    hebasto commented at 4:19 pm on July 19, 2020: member

    @alexstrbonn

    Will this be only fixed once 0.20.1 will be available?

    You already could test v0.20.1rc1 :)

27. 
    MarcoFalke commented at 4:24 pm on July 19, 2020: member

    rc1 binaries will be downloadable early this week. If nothing goes wrong, the final release will be out early next week.
28. backpacker69 referenced this in commit 2d03b59b85 on Sep 8, 2020
29. jasonbcox referenced this in commit 0bd424bcb8 on Oct 5, 2020
30. fanquake referenced this in commit a8411b3d9c on Oct 14, 2020
31. fanquake removed the label Needs backport (0.19) on Oct 15, 2020
32. 
    fanquake commented at 2:55 am on October 15, 2020: member

    Being backported to 0.19 in #20150.
33. Bushstar referenced this in commit 4e29ae271e on Oct 21, 2020
34. Platinumwrist referenced this in commit 05e2740d92 on Oct 25, 2020
35. MarkLTZ referenced this in commit 7ba0daba93 on Nov 7, 2020
36. MarcoFalke referenced this in commit 5baaea4410 on Dec 2, 2020
37. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto theuni Sjors fanquake alexstrbonn MarcoFalke

Labels
Build system

Milestone
0.19.2