Build broken without miniupnpc #196

pull amiryal wants to merge 1 commits into bitcoin:master from amiryal:master changing 1 files +6 −3

amiryal commented at 8:40 PM on May 5, 2011: contributor
Hi,

My build broke saying:
```
net.cpp:8: fatal error: miniupnpc/miniwget.h: No such file or directory
```
So I fixed it and made a patch. The patch was made and tested against v0.3.21 on a GNU/Linux, but it should be good to apply on master as well. Also, it was not tested with USE_UPNP=1, but I don't see why it should fail.

Yours, Amir
TheBlueMatt commented at 9:54 PM on May 5, 2011: member

I'm getting kind of tired of explaining this. USE_UPNP=1 means UPnP is on by default. USE_UPNP=0 means UPnP is compiled in and off by default. If you undefine USE_UPNP by building with USE_UPNP= UPnP is not compiled in any the errors go away. Please do a bit of searching before submitting bug/pull requests.
Clarify the meaning of USE_UPNP in build-unix.txt 894031bbd9
amiryal commented at 8:04 AM on May 6, 2011: contributor

OK, thanks for the clarification! Now if you pull my revised patch, people will get this clarification in build-unix.txt.
TheBlueMatt commented at 9:31 AM on May 6, 2011: member

Now that is a great idea. (and here I was thinking that was already in there) sorry for going off on you.
amiryal commented at 9:59 AM on May 6, 2011: contributor

Your earlier comment was constructive nonetheless – no offense taken. :)
jgarzik referenced this in commit 62b427ec55 on May 6, 2011
jgarzik merged this on May 6, 2011
jgarzik closed this on May 6, 2011
sipa referenced this in commit 9d09322b41 on Mar 27, 2015
TheBlueMatt referenced this in commit 582b2934e6 on Oct 20, 2015
btcdrak referenced this in commit 49d5d31693 on Nov 28, 2015
deadalnix referenced this in commit bac1bfcdcb on Jan 3, 2017
deadalnix referenced this in commit 7137be8110 on Jan 19, 2017
lateminer referenced this in commit fbefe8fa69 on Dec 9, 2017
classesjack referenced this in commit bffc311168 on Jan 2, 2018
attilaaf referenced this in commit 7440ff1d91 on Jan 13, 2020
rajarshimaitra referenced this in commit 728ad2e4f9 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

amiryal

TheBlueMatt

Linked (view graph)

#25323 miniscript fuzzer failing after qa-assets update