Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded.
Something similar is already done for the command line and config file. See:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
No conflicts as of last run.
439+ SaveErrors({val_error}, errors);
440+ return false;
441+ }
442+ } else {
443+ LogPrintf("Ignoring unknown rw_settings value %s\n", setting.first);
444+ }
In commit “Interpret and validate rw_settings” (faec629663a92f28c5328ab3877ff58847bf9e35)
Would suggest just:
0if (!flags) {
1 LogPrintf("Ignoring unknown rw_settings value %s\n", setting.first);
2}
I don’t think this can return false and prevent loading all settings when one has an unrecognized value, because it could break downgrading if allowed values are expanded, similar to what’s described #15935 (comment). I also tend to think there shouldn’t call a new call to CheckValid while that function is basically broken and its behavior is being worked out in other PRs.
CheckValid for now
54@@ -55,6 +55,13 @@ def run_test(self):
55 fp.write("invalid json")
56 node.assert_start_raises_init_error(expected_msg='Unable to parse settings file', match=ErrorMatch.PARTIAL_REGEX)
57
58+ # Test invalid type
59+ with settings.open("w") as fp:
60+ json.dump({"blockversion": False}, fp)
61+ node.assert_start_raises_init_error(
62+ expected_msg='Error: Failed loading settings file:\n- Negating of -blockversion is meaningless and therefore forbidden',
In commit “Disallow negation of blockversion” (fa1c4c9c7d10c11b0a2324ff0377919fa9fbc2fe)
I don’t think having this second commit in this PR is a good idea. It’s not directly related to the extra logging that this PR provides (which seems unambiguously good), and it’s not a backwards compatible change, and it diverges from previous and still widespread behavior where -noarg is equivalent to arg=0. Changing command line processing could be good but I think it’d better to do it in a dedicated PR with more consistency and without tying it to another change
