test: Wait for ‘cmpctblock’ in p2p_compactblocks when it is expected #19631

1. 
   Empact commented at 11:16 pm on July 30, 2020: member

   This is a more narrowly-construed wait which eliminates the possibility of the wait being triggered by other messages.

   Note received_block_announcement reflect three possible messages: https://github.com/bitcoin/bitcoin/blob/edec7f7c254294cd5c46ae5cf304353d458bb852/test/functional/p2p_compactblocks.py#L34-L53

   Prompted by looking into: #19449

2. test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected

   This is a more narrowly-construed wait which eliminates the possibility of the
   wait being triggered by other messages.
   
   Co-authored-by: Billy Garrison <billygarrison.btc@gmail.com>

   9e165d0de4
3. fanquake added the label Tests on Jul 30, 2020
4. 
   DrahtBot commented at 4:00 am on July 31, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

5. theStack approved
6. 
   theStack commented at 3:38 pm on August 6, 2020: member

   ACK https://github.com/bitcoin/bitcoin/pull/19631/commits/9e165d0de4c3cd168137fc85b8f31b371bd4e851 Waiting for message type x is better than waiting for message types x, y, z if only x is expected :)
7. 
   laanwj commented at 4:47 pm on August 9, 2020: member

   Code review ACK 9e165d0de4c3cd168137fc85b8f31b371bd4e851
8. laanwj merged this on Aug 9, 2020
9. laanwj closed this on Aug 9, 2020

   ---

10. sidhujag referenced this in commit eaa8d08bf3 on Aug 9, 2020
11. Empact deleted the branch on Aug 14, 2020
12. Fabcien referenced this in commit 0a4beac5f0 on Sep 7, 2021
13. PastaPastaPasta referenced this in commit 29132a1b16 on Sep 17, 2021
14. kittywhiskers referenced this in commit 619b414691 on Oct 12, 2021
15. DrahtBot locked this on Feb 15, 2022

Contributors
Empact DrahtBot theStack laanwj

Labels
Tests