Avoid locking CTxMemPool::cs recursively in Mempool{Info}ToJSON() #19652

1. 
   hebasto commented at 1:26 pm on August 3, 2020: member

   Split out from #19306.

   Only trivial thread safety annotations and lock assertions added. No new locks. No behavior change.

   This is a step to make CTxMemPool::cs an instance of Mutex rather RecursiveMutex.

2. hebasto marked this as a draft on Aug 3, 2020
3. hebasto force-pushed on Aug 3, 2020
4. hebasto marked this as ready for review on Aug 3, 2020
5. DrahtBot added the label RPC/REST/ZMQ on Aug 3, 2020
6. DrahtBot added the label Tests on Aug 3, 2020
7. 
   practicalswift commented at 3:48 pm on August 3, 2020: contributor

   Concept ACK: thanks for adding thread-safety annotations!
8. 
   DrahtBot commented at 6:55 pm on August 3, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19806 (validation: UTXO snapshot activation by jamesob)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. hebasto renamed this:
   Add thread safety annotations to Mempool{Info}ToJSON()
   Avoid locking CTxMemPool::cs recursively in Mempool{Info}ToJSON()
   on Sep 6, 2020
10. DrahtBot added the label Needs rebase on Sep 23, 2020
11. hebasto force-pushed on Nov 8, 2020
12. 
    hebasto commented at 9:20 pm on November 8, 2020: member

    Rebased ef803c32d28d103b548fa5eb18b6faa17c7153cf -> dd427ddc4d3570aa0afbccb10869703366ea6cb1 (pr19652.02 -> pr19652.03) due to the conflict with #19572.
13. DrahtBot removed the label Needs rebase on Nov 8, 2020
14. DrahtBot added the label Needs rebase on Dec 7, 2020
15. refactor: Add thread safety annotations to Mempool{Info}ToJSON()

    This change avoids locking CTxMemPool::cs recursively in
    Mempool{Info}ToJSON() functions.

    09b1ef2262
16. hebasto force-pushed on Dec 7, 2020
17. 
    hebasto commented at 2:04 pm on December 7, 2020: member

    Rebased dd427ddc4d3570aa0afbccb10869703366ea6cb1 -> 09b1ef2262e72e708b71a3e70948f8a42ceb1030 (pr19652.03 -> pr19652.04) due to the conflict with #18766.
18. DrahtBot removed the label Needs rebase on Dec 7, 2020
19. 
    DrahtBot commented at 8:21 pm on February 16, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

20. DrahtBot added the label Needs rebase on Feb 16, 2021
21. hebasto closed this on Aug 24, 2021

    ---

22. DrahtBot locked this on Aug 24, 2022

Contributors
hebasto practicalswift DrahtBot

Labels
Tests RPC/REST/ZMQ Needs rebase