refactor: make EncodeBase{32,64} consume Spans #19687

1. 
   theStack commented at 11:12 am on August 8, 2020: member

   To simplify the interface of the Base32/Base64 encoding functions for raw data, this PR changes them from taking two arguments (pointer and length) to just one Span. Most calls to EncodeBase64 pass data from CDataStream instances, which unfortunately internally work with char* pointers rather than unsigned char*, but thanks to the recently introduced MakeUCharSpan helper, converting them is quite easy.
2. DrahtBot added the label P2P on Aug 8, 2020
3. DrahtBot added the label Refactoring on Aug 8, 2020
4. DrahtBot added the label RPC/REST/ZMQ on Aug 8, 2020
5. DrahtBot added the label Utils/log/libs on Aug 8, 2020
6. MarcoFalke removed the label P2P on Aug 8, 2020
7. MarcoFalke removed the label RPC/REST/ZMQ on Aug 8, 2020
8. 
   DrahtBot commented at 8:47 pm on August 8, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

9. 
   laanwj commented at 2:43 pm on August 9, 2020: member

   Code review and concept ACK 08e73a2abf0035305b2d1a08f62161cd36cb39a5
10. 
    promag commented at 8:17 am on August 10, 2020: member

    Concept ACK
11. vasild approved
12. 
    vasild commented at 12:48 pm on August 10, 2020: member

    ACK 08e73a2ab
13. 
    fanquake commented at 12:55 pm on August 10, 2020: member

    @sipa want to take a look here given you’ve also been doing Span things?
14. 
    laanwj commented at 10:55 am on August 12, 2020: member

    We might want to merge this after #19628 due to the conflicts in CNetAddr.
15. laanwj referenced this in commit 44ddcd887d on Aug 19, 2020
16. sidhujag referenced this in commit d2b5dc4fbc on Aug 19, 2020
17. DrahtBot added the label Needs rebase on Aug 25, 2020
18. util: make EncodeBase32 consume Spans 2bc207190e
19. util: make EncodeBase64 consume Spans e2aa1a585a
20. theStack force-pushed on Aug 25, 2020
21. 
    theStack commented at 5:10 pm on August 25, 2020: member

    Rebased on master, now that #19628 has been merged :tea:
22. DrahtBot removed the label Needs rebase on Aug 25, 2020
23. vasild approved
24. 
    vasild commented at 7:47 am on August 26, 2020: member

    ACK e2aa1a585
25. 
    MarcoFalke commented at 9:51 am on August 26, 2020: member

    ACK e2aa1a585a83971639572cd2c84565ec360deac9 🐮

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3ACK e2aa1a585a83971639572cd2c84565ec360deac9 🐮
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUhs1Qv/QF5OYwppGsljksi+aAtIQl4ak8TlPxkTzbTTt0yKnxT0cll0Wi3mBjpl
     8KnH0WqaKoGPpKX2WuZMDEw6ElIrGn2m8NKHHGDPd6RV+/VsXsoqJTfN0b9EyxOR1
     9b8I7WzTQ55sCOz9qxod2VwRhYupjJLaKPrOHkEsJbu+Cdp1W4V31nBK0le/Sbz3k
    101P+kGTQBQJ4J7/R3ut6uv1AQM/yagTNIYJyujQ8dfaMY9W0463oBmzEZUC0Onn0n
    11KD7lz9PhTy+Fab+eS4KGXqvdNwbTND5cC98ZbabeZYTtySOviXuuAOTkE/wqWAoW
    12Y/BujW0WCR7RkKafTww4ehdHu4hM9EBu6XmUBJoN0WGnLz9tc4lzut7gEZVDdAxf
    130H9iKZG8rRSjmaGLylRsN7ZVTrd4RI2cYOZgdW1tHXB3/9cjqCe8t8WLAKAbpbZd
    14Cqt42I0/3k1sSOs09RuYm1U6PRJPKdUiQsGTwEG1JHVwqfHmkJh27y8VFLNP6Lts
    15ExD2MEbH
    16=DLNB
    17-----END PGP SIGNATURE-----
    

    Timestamp of file with hash 6167e6861d81d53ab89ae9db25b356c5a5eeb5c7f418be3c91e0cec0355a00bf -

26. MarcoFalke merged this on Aug 26, 2020
27. MarcoFalke closed this on Aug 26, 2020

    ---

28. theStack deleted the branch on Dec 1, 2020
29. Fabcien referenced this in commit 545de4f0d2 on Feb 9, 2021
30. kittywhiskers referenced this in commit a9ee7ab13f on May 18, 2021
31. kittywhiskers referenced this in commit b05773ffd4 on May 20, 2021
32. kittywhiskers referenced this in commit f757937b52 on May 20, 2021
33. kittywhiskers referenced this in commit 8ae49136bb on May 21, 2021
34. kittywhiskers referenced this in commit 9dad315032 on May 22, 2021
35. kittywhiskers referenced this in commit 065cc46b91 on May 23, 2021
36. PastaPastaPasta referenced this in commit 41a8349d4d on May 23, 2021
37. random-zebra referenced this in commit 56f10aaa51 on Jul 21, 2021
38. random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
39. DrahtBot locked this on Feb 15, 2022

Contributors
theStack DrahtBot laanwj promag vasild fanquake MarcoFalke

Labels
Refactoring Utils/log/libs