Move comment about BaseIndex::DB from TxIndex::DB #19733

1. 
   marcinja commented at 10:21 pm on August 15, 2020: contributor

   Moves a comment about the BaseIndex::DB from the TxIndex::DB into the correct place. Originally part of #14053.
2. DrahtBot added the label UTXO Db and Indexes on Aug 16, 2020
3. 
   promag commented at 11:30 pm on August 16, 2020: member

   ACK 68b597b81395e026e299bca05e46312f273f812b.
4. 
   jnewbery commented at 9:59 am on August 17, 2020: member

   ACK 68b597b81395e026e299bca05e46312f273f812b
5. 
   jonatack commented at 10:26 am on August 17, 2020: member

   ACK 68b597b
6. 
   MarcoFalke commented at 11:05 am on August 17, 2020: member

   Needs rebase, and I see your previous commit had some apparent unused includes. If you agree, you can add a commit here to remove them:

    0diff --git a/src/index/disktxpos.h b/src/index/disktxpos.h
    1index 8cd2270028..129f9dc7c0 100644
    2--- a/src/index/disktxpos.h
    3+++ b/src/index/disktxpos.h
    4@@ -5,10 +5,8 @@
    5 #ifndef BITCOIN_INDEX_DISKTXPOS_H
    6 #define BITCOIN_INDEX_DISKTXPOS_H
    7 
    8-#include <chain.h>
    9 #include <flatfile.h>
   10-#include <primitives/block.h>
   11-#include <primitives/transaction.h>
   12+#include <serialize.h>
   13 
   14 struct CDiskTxPos : public FlatFilePos
   15 {
   16@@ -33,5 +31,4 @@ struct CDiskTxPos : public FlatFilePos
   17     }
   18 };
   19 
   20-
   21 #endif // BITCOIN_INDEX_DISKTXPOS_H
   

7. MarcoFalke added the label Needs rebase on Aug 17, 2020
8. marcinja force-pushed on Aug 17, 2020
9. DrahtBot removed the label Needs rebase on Aug 17, 2020
10. Move comment about BaseIndex::DB from TxIndex::DB cf095a53fc
11. Remove unused includes 8ed2f1ed78
12. marcinja force-pushed on Aug 19, 2020
13. 
    DrahtBot commented at 8:17 pm on August 20, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14053 (Add address-based index (attempt 4?) by marcinja)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. fanquake approved
15. 
    fanquake commented at 4:48 am on August 21, 2020: member

    ACK 8ed2f1ed78937eff0bb8b5318a30da908e33af24
16. fanquake merged this on Aug 21, 2020
17. fanquake closed this on Aug 21, 2020

    ---

18. sidhujag referenced this in commit e954a012af on Aug 21, 2020
19. vijaydasmp referenced this in commit 909c5fa563 on Sep 15, 2021
20. deadalnix referenced this in commit bcb68a351d on Sep 15, 2021
21. vijaydasmp referenced this in commit f3165ddc45 on Sep 16, 2021
22. PastaPastaPasta referenced this in commit 4526efc6ac on Sep 17, 2021
23. vijaydasmp referenced this in commit a97683ff3a on Sep 20, 2021
24. vijaydasmp referenced this in commit 71df8f25db on Sep 20, 2021
25. vijaydasmp referenced this in commit 829aeff0f6 on Sep 22, 2021
26. UdjinM6 referenced this in commit da26b9bff8 on Sep 24, 2021
27. kittywhiskers referenced this in commit c1d2c79f4d on Oct 12, 2021
28. MarcoFalke locked this on Feb 15, 2022

Contributors
marcinja promag jnewbery jonatack MarcoFalke DrahtBot fanquake

Labels
UTXO Db and Indexes