signrawtransactionwithwallet fails to sign non-wallet inputs (0.20 only; before/after already fixed) #19737

issue luke-jr opened this issue on August 16, 2020

luke-jr commented at 10:37 PM on August 16, 2020: member

#17204 introduced a test that uses signrawtransactionwithwallet to sign a non-wallet input (providing the necessary solution as a param).

At least 0.20 didn't allow this. Bisect reveals that the behaviour change was in bde7c9fa38775a81d53ac0484fa9c98076a0c7d1 (part of #16528, descriptor wallets).

Is this change intended behaviour, or a bug?
luke-jr added the label Bug on Aug 16, 2020
fanquake added the label Wallet on Aug 17, 2020
fanquake commented at 12:23 AM on August 17, 2020: member

cc @jonatack
achow101 commented at 12:57 AM on August 17, 2020: member

This is intended behavior and actually appears to be a regression in 0.20.

The test passes on 0.19. The failure in 0.20 looks to be because we aren't correctly handling the condition where a transaction being signed is already fully signed and it's just falling through to a return false. I guess this was accidentally fixed.
luke-jr renamed this:
~~signrawtransactionwithwallet signs non-wallet inputs~~
signrawtransactionwithwallet fails to sign non-wallet inputs (0.20 only; before/after already fixed)
on Aug 17, 2020
MarcoFalke referenced this in commit 953dddbd20 on Dec 10, 2020
MarcoFalke closed this on Dec 11, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels