refactor: remove c-string interfaces for DecodeBase58{Check} #19739

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20200811-util-remove-cstring-decodebase58 changing 2 files +2 −15

theStack commented at 12:03 AM on August 17, 2020: member

This micro-PR gets rid of base58 function interfaces that are redundant in terms of c-string / std::string variants; the c-string interface for DecodeBase58Check is completely unused outside the base58 module, while the c-string interface for DecodeBase58 is only used in unit tests, where an implicit conversion to std::string is not problematic.
fanquake added the label Refactoring on Aug 17, 2020
practicalswift commented at 11:06 AM on August 17, 2020: contributor

Thanks for removing old cruft with potentially sharp edges! But please don't remove the NODISCARD annotation :)

ACK 13e576171d815d024f211593523c4c8204789f4a modulo restoration of NODISCARD
util: remove c-string interfaces for DecodeBase58{Check} d3e8adfada
theStack force-pushed on Aug 17, 2020
theStack commented at 11:18 AM on August 17, 2020: member

@practicalswift: Thanks for reviewing! Good point, force-pushed with adding the NODISCARD annotations for the respective (now static) functions in the base 58 module.
practicalswift commented at 2:41 PM on August 17, 2020: contributor

ACK d3e8adfada889a3c9fba930086eda609509aca07 -- patch looks correct
laanwj referenced this in commit e9b3012654 on Aug 19, 2020
sidhujag referenced this in commit 8a92011d67 on Aug 19, 2020
laanwj commented at 2:50 PM on August 28, 2020: member

Code review ACK d3e8adfada889a3c9fba930086eda609509aca07
laanwj merged this on Aug 28, 2020
laanwj closed this on Aug 28, 2020
sidhujag referenced this in commit de0e6f081c on Aug 28, 2020
theStack deleted the branch on Dec 1, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19749 Intermittent CI failure: wallet_groups.py #19750 refactor: remove unused c-string variant of atoi64()