We do not ship 32-bit x86 Linux binaries (#17504, #18104), therefore, this PR removes unused code.
build: Drop back compatibility code for 32-bit x86 Linux binaries #19745
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200817-i686 changing 2 files +2 −5-
hebasto commented at 8:55 AM on August 17, 2020: member
-
build: Drop back compatibility code for 32-bit x86 Linux binaries 5ddce5563c
- fanquake added the label Build system on Aug 17, 2020
-
MarcoFalke commented at 9:18 AM on August 17, 2020: member
This will be removed anyway when we bump glibc for the 0.22 release? If yes, might as well not touch the code for now and do the wholesale removal on Nov 1st
- hebasto closed this on Aug 17, 2020
-
-
laanwj commented at 10:01 AM on August 17, 2020: member
Please do not break build compatibility with 32-bit x86. Yes, we no longer distribute binaries for it, but I think it's OK if people build their own binaries for it! (and I think we promised as such, to not break compatibility with 32-bit x86 for self-builders)
-
hebasto commented at 10:05 AM on August 17, 2020: member
The removed code was used for shipped binaries only. People always can build their own binaries dynamically linked to system libs, no?
On Mon, 17 Aug 2020 at 13:01, Wladimir J. van der Laan < notifications@github.com> wrote:
Please do not break build compatibility with 32-bit x86. Yes, we no longer distribute binaries for it, but I think it's OK if people build their own binaries for it!
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/19745#issuecomment-674786916, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPQGYY42C6F56TA6EULSBD5XXANCNFSM4QBNGFKQ .
--
-- Hennadii Stepanov
-
laanwj commented at 10:10 AM on August 17, 2020: member
Sure, I guess it's okay in this case, I just meant it in general, this is not the kind of PR I'd like to encourage.
- DrahtBot locked this on Feb 15, 2022
