build: Skip i686 build by default in guix and gitian #18104

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2002-i686NoBuildByDefault changing 5 files +4 −5

MarcoFalke commented at 9:08 PM on February 9, 2020: member

Closes #17504

Now that we no longer provide downloads for i686 on our website (https://bitcoincore.org/en/download/), there is no need to build them by default.

i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate HOSTS.
MarcoFalke added the label Build system on Feb 9, 2020
MarcoFalke added the label Needs gitian build on Feb 9, 2020

depends: Remove reference to win32

win32 is no longer mentioned in doc/build-windows.md

fa55a2554c

build: Skip i686 build by default in guix and gitian fae9084ac5
MarcoFalke force-pushed on Feb 9, 2020
DrahtBot commented at 1:10 AM on February 10, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17595 (guix: Enable building for x86_64-w64-mingw32 target by dongcarl)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj commented at 10:44 AM on February 10, 2020: member

Code review ACK fae9084ac5b10f94bdee54853d307838c4254e9c Travis fail is the usual s390 fail.
hebasto approved
hebasto commented at 2:54 PM on February 10, 2020: member

ACK fae9084ac5b10f94bdee54853d307838c4254e9c, I have reviewed the code and it looks OK, I agree it can be merged.
practicalswift commented at 3:39 PM on February 10, 2020: contributor

ACK fae9084ac5b10f94bdee54853d307838c4254e9c -- patch looks correct
dongcarl commented at 4:19 PM on February 10, 2020: member

~~Nice! Could probably also remove~~ https://github.com/bitcoin/bitcoin/blob/4c2578706c70148fc001f42a0918a2fb10252b43/contrib/guix/manifest.scm#L150 ~~but not a huge deal.~~

My bad I didn't see "i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate HOSTS."

ACK fae9084ac5b10f94bdee54853d307838c4254e9c patch looks correct
fanquake referenced this in commit 98264e2ccb on Feb 11, 2020
fanquake merged this on Feb 11, 2020
fanquake closed this on Feb 11, 2020
MarcoFalke deleted the branch on Feb 11, 2020

DrahtBot commented at 1:30 PM on February 11, 2020: member

Gitian builds

File	commit 646f0ada0205ae4b3952107e3b1542f06adda32b<br>(master)	commit e0e64f6699121aff6a8e1291c9d25092df25470b<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`9a0f845f3f6be5be...`	`6e360a27965d687c...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`8a25b2286ed0794b...`	`bf1f340297fb2f03...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`1fee3b11eca20046...`	`739b25d36fd4ee84...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`2a8402a41d62e989...`	`2fe351b4f97fb226...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`79ec741e2c97bcb4...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`8a6bab3030e3f102...`
bitcoin-0.19.99-osx-unsigned.dmg	`4a836641d200ad86...`	`04300c89f0a6185f...`
bitcoin-0.19.99-osx64.tar.gz	`574878c954f65336...`	`b0673a72c47a8306...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`8a5ffb502fdfbfea...`	`eebf7815cd91d024...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`0c4b9bed5092f6f4...`	`a098a8ef427152cb...`
bitcoin-0.19.99-win64-debug.zip	`e0e0db49aba2546f...`	`d88e882e17e10ca0...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`bf40c7f5f0bb6a86...`	`30f21fe4f5cf454d...`
bitcoin-0.19.99-win64.zip	`338932e900951da5...`	`8c76fcaac536c964...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`1fd82e68bd642dcd...`	`7d172e7d2f935172...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`e45163e3c0d929b5...`	`a366c5cbc480056a...`
bitcoin-0.19.99.tar.gz	`c31ddf1517a24061...`	`067620a174f9431a...`
bitcoin-core-linux-0.20-res.yml	`f00d3705cd81465d...`	`44c610b19cc97d7e...`
bitcoin-core-osx-0.20-res.yml	`eae4b251bcbc5229...`	`1480f0cc1f76b2e0...`
bitcoin-core-win-0.20-res.yml	`82e598951b1e2b57...`	`546af43b8b2d736e...`
linux-build.log	`37875d5a1634e188...`	`301e4ac81b6d6c67...`
osx-build.log	`4e66c49954c10965...`	`d4ef35d072457da6...`
win-build.log	`a7274ebd8b614c4a...`	`9c6866a33cb87022...`
bitcoin-core-linux-0.20-res.yml.diff		`14826e17f75c3718...`
bitcoin-core-osx-0.20-res.yml.diff		`4b8db01fd2907821...`
bitcoin-core-win-0.20-res.yml.diff		`a43bcaff53ac6144...`
linux-build.log.diff		`209bcaa9fdf2ce91...`
osx-build.log.diff		`26b916c60783179d...`
win-build.log.diff		`001be83b5a193812...`

DrahtBot removed the label Needs gitian build on Feb 11, 2020
dnprock commented at 10:17 PM on March 23, 2020: none

@MarcoFalke I came across this PR. I notice there's still references to i686 in gitian-linux descriptor.

https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L103

Should they be removed as well?
hebasto commented at 8:42 PM on March 28, 2020: member

@dnprock

@MarcoFalke I came across this PR. I notice there's still references to i686 in gitian-linux descriptor.

https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml#L103

Should they be removed as well?

From the OP:

i686 can still be built in depends (tested by ci/travis) and in guix/gitian by setting the appropriate HOSTS.
MarkLTZ referenced this in commit 24ef8ef089 on Apr 10, 2020
laanwj referenced this in commit e653a80d7c on Jun 3, 2020
luke-jr referenced this in commit 3fc8668a86 on Jun 9, 2020
deadalnix referenced this in commit 32bbcb69bd on Aug 20, 2020
luke-jr referenced this in commit dd67dff65f on Oct 10, 2021
UdjinM6 referenced this in commit 8e7bf394d1 on Oct 23, 2021
luke-jr referenced this in commit 47f77b251f on Nov 9, 2021
UdjinM6 referenced this in commit b5f5bf7330 on Dec 4, 2021
UdjinM6 referenced this in commit 632c759352 on Dec 5, 2021
DrahtBot locked this on Feb 15, 2022