net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes #19797

1. 
   i-rme commented at 10:42 pm on August 24, 2020: contributor

   The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.

   This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).

   Credits for discovering this go to sipa in #19628 (review)

   Thanks for the attention!

2. fanquake added the label P2P on Aug 24, 2020
3. 
   DrahtBot commented at 7:19 am on August 25, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

4. 
   instagibbs commented at 3:10 pm on August 25, 2020: member

   Can modern Core nodes even talk to those nodes on p2p?

   utACK https://github.com/bitcoin/bitcoin/pull/19797/commits/2c1f59c9270cf528325a8ca1a717e9246a61a7bd

5. 
   jonatack commented at 4:11 pm on August 25, 2020: member

   Can modern Core nodes even talk to those nodes on p2p?

   Nope: #19628 (review)

6. 
   jonatack commented at 4:12 pm on August 25, 2020: member

   @i-rme suggest updating the PR description to reference #19628 (review) rather than twitter.
7. DrahtBot added the label Needs rebase on Aug 25, 2020
8. 
   i-rme commented at 5:44 pm on August 25, 2020: contributor

   @i-rme suggest updating the PR description to reference #19628 (comment) rather than twitter.

   Added that reference since I was not aware of it before.

9. 
   jonatack commented at 5:51 pm on August 25, 2020: member

   Thanks for updating. You’ll need to rebase.
10. i-rme force-pushed on Aug 25, 2020
11. 
    i-rme commented at 6:46 pm on August 25, 2020: contributor

    Rebased
12. vasild approved
13. 
    vasild commented at 7:28 pm on August 25, 2020: member

    ACK dba98c830
14. 
    jonatack commented at 7:35 pm on August 25, 2020: member

    utACK dba98c8304db9f2e854d8bf4f1ca3ae81d5a8eef
15. DrahtBot removed the label Needs rebase on Aug 25, 2020
16. 
    practicalswift commented at 9:00 pm on August 25, 2020: contributor

    Concept ACK: I’m afraid we’ll have to deviate slightly from Satoshi’s original vision here!
17. MarcoFalke renamed this:
    net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node …
    net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes
    on Aug 26, 2020
18. 
    laanwj commented at 6:41 am on August 27, 2020: member

    Code review ACK Please remove the @ from your commit message (it leads to the @’ed people getting lots of notifications).
19. fanquake added the label Waiting for author on Aug 27, 2020
20. i-rme force-pushed on Aug 28, 2020
21. Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages

    The change removes an old check for IPv6 addresses in range ::ff:ff00:0:0:0/72 that were created due to a bug in size field of addr messages for 0.2.8 nodes and before.
    
    This check is no longer needed as they are no more pre 0.2.9 nodes on the network (as per bitnodes network snapshot).
    
    Credits for discovering this go to sipa.

    7b6d0f10a7
22. i-rme force-pushed on Aug 28, 2020
23. 
    i-rme commented at 12:18 pm on August 28, 2020: contributor

    Removed the @ from the commit message to avoid notifications.
24. vasild approved
25. 
    vasild commented at 12:32 pm on August 28, 2020: member

    ACK 7b6d0f1
26. 
    sipa commented at 3:46 pm on August 28, 2020: member

    utACK 7b6d0f10a7af7998f7cfcf3aeaa0269b61a321ce
27. MarcoFalke merged this on Aug 28, 2020
28. MarcoFalke closed this on Aug 28, 2020

    ---

29. fanquake removed the label Waiting for author on Aug 30, 2020
30. PastaPastaPasta referenced this in commit f67aba4862 on Jun 27, 2021
31. PastaPastaPasta referenced this in commit 69e2115b46 on Jun 28, 2021
32. PastaPastaPasta referenced this in commit ae0ae43c01 on Jun 29, 2021
33. PastaPastaPasta referenced this in commit 10c3d63f2c on Jul 1, 2021
34. PastaPastaPasta referenced this in commit 1988592ea7 on Jul 1, 2021
35. PastaPastaPasta referenced this in commit 1ff7090066 on Jul 15, 2021
36. PastaPastaPasta referenced this in commit 5dc39741e9 on Jul 16, 2021
37. Fabcien referenced this in commit f13fc65c57 on Sep 17, 2021
38. DrahtBot locked this on Feb 15, 2022

Contributors
i-rme DrahtBot instagibbs jonatack vasild practicalswift laanwj sipa

Labels
P2P