doc: elaborate on release notes wrt netmasks #19802

pull vasild wants to merge 1 commits into bitcoin:master from vasild:elaborate_netmasks_relnotes changing 1 files +2 −1
  1. vasild commented at 4:39 pm on August 25, 2020: member

    doc: elaborate on release notes wrt netmasks

    A minor followup from #19628 (comment).

  2. DrahtBot added the label Docs on Aug 25, 2020
  3. doc: elaborate on release notes wrt netmasks 8de51d1513
  4. in doc/release-notes.md:144 in 04921cd93f outdated
    140@@ -141,7 +141,8 @@ Updated settings
    141 
    142 - Netmasks that contain 1-bits after 0-bits (the 1-bits are not contiguous on
    143   the left side, e.g. 255.0.255.255) are no longer accepted. They are invalid
    144-  according to RFC 4632.
    145+  according to RFC 4632. Netmasks are used in the `-rpcallowip` parameter and
    


    jonatack commented at 2:02 pm on August 26, 2020:
    • perhaps s/parameter/option|configuration option/ (Usage: bitcoind [options])

    • per bitcoind -help-debug | grep -C3 -i cidr and git grep -ni netmask, maybe verify if netmasks are also used for the -whitelist option


    vasild commented at 1:29 pm on September 1, 2020:
    Updated, thanks!
  5. vasild force-pushed on Sep 1, 2020
  6. jonatack commented at 1:41 pm on September 1, 2020: member
    LGTM, thanks for the changes per git diff 04921cd 8de51d1
  7. laanwj commented at 12:48 pm on September 10, 2020: member
    ACK https://github.com/bitcoin/bitcoin/pull/19802/commits/8de51d1513ada6d96b80f164da48088e5cdcbe3f The travis lint run error seems like soms kind of unrelated network corruption issue, but running it again just in case.
  8. theStack approved
  9. theStack commented at 1:08 pm on September 12, 2020: member
    ACK 8de51d1513ada6d96b80f164da48088e5cdcb Checked where in the code subnet parsing happens via git grep LookupSubNet.
  10. practicalswift commented at 6:54 am on September 13, 2020: contributor
    ACK 8de51d1513ada6d96b80f164da48088e5cdcbe3f
  11. laanwj merged this on Sep 30, 2020
  12. laanwj closed this on Sep 30, 2020

  13. sidhujag referenced this in commit 079ccad86e on Sep 30, 2020
  14. Fabcien referenced this in commit 1bc6f8147f on Feb 5, 2021
  15. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me