test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles #19830

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2008-testTsan changing 1 files +1 −0

MarcoFalke commented at 7:57 AM on August 29, 2020: member

Fixes #19712
test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles fa1fc536bb
fanquake added the label Tests on Aug 29, 2020
hebasto approved

hebasto commented at 8:43 AM on August 29, 2020: member

ACK fa1fc536bb26471fd2a6fe8d12f98cf53c646306

The excerpt from the log on master:

WARNING: ThreadSanitizer: data race (pid=116734)
  Write of size 8 at 0x7ba0000000c0 by thread T22 (mutexes: write M132382):
    [#0](/bitcoin-bitcoin/0/) closedir <null> (bitcoind+0x78ea6)
    [#1](/bitcoin-bitcoin/1/) leveldb::(anonymous namespace)::PosixEnv::GetChildren(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >*) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/leveldb/util/env_posix.cc:599:5 (bitcoind+0x756376)
    [#2](/bitcoin-bitcoin/2/) leveldb::DBImpl::DeleteObsoleteFiles() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/leveldb/db/db_impl.cc:237:9 (bitcoind+0x721f49)
    [#3](/bitcoin-bitcoin/3/) leveldb::DBImpl::BackgroundCompaction() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/leveldb/db/db_impl.cc:752:5 (bitcoind+0x725b2e)
    [#4](/bitcoin-bitcoin/4/) leveldb::DBImpl::BackgroundCall() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/leveldb/db/db_impl.cc:687:5 (bitcoind+0x725488)
    [#5](/bitcoin-bitcoin/5/) leveldb::DBImpl::BGWork(void*) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/leveldb/db/db_impl.cc:676:34 (bitcoind+0x7253c7)

MarcoFalke commented at 8:55 AM on August 29, 2020: member

Here's the log on libstdc++: https://cirrus-ci.com/task/5957926764412928?command=ci#L4594
practicalswift commented at 9:13 AM on August 29, 2020: contributor

ACK fa1fc536bb26471fd2a6fe8d12f98cf53c646306 -- patch looks correct

Thanks for keeping the suppressions up to date! ❤️
fanquake merged this on Aug 31, 2020
fanquake closed this on Aug 31, 2020
MarcoFalke deleted the branch on Aug 31, 2020
sidhujag referenced this in commit fcd64f6295 on Aug 31, 2020
Fabcien referenced this in commit 6dfd02250f on Sep 17, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19712 test: Data race detected when running rpc_blockchain.py