rpc: Properly deserialize txs with witness before signing #19836

1. 
   MarcoFalke commented at 8:35 AM on August 30, 2020: member

   Signing a transaction can only happen when the transaction has inputs. A transaction with inputs can always be deserialized as witness-transaction. If try_no_witness decoding is attempted, this will lead to rare intermittent failures.

   Fixes #18803

2. rpc: Properly deserialize txs with witness before signing cccc752569
3. MarcoFalke added the label RPC/REST/ZMQ on Aug 30, 2020
4. MarcoFalke added the label Needs backport (0.19) on Aug 30, 2020
5. MarcoFalke added the label Needs backport (0.18) on Aug 30, 2020
6. MarcoFalke added the label Needs backport (0.20) on Aug 30, 2020
7. 
   MarcoFalke commented at 8:36 AM on August 30, 2020: member

   This may have been introduced in commit 6b4f231f5f0f88690488c4da20ea1c180dbc4b19, in which case it needs backport to all currently supported, released versions of Bitcoin Core.

8. 
   MarcoFalke commented at 8:42 AM on August 30, 2020: member

   See also #15899

9. fanquake requested review from achow101 on Aug 31, 2020
10. 
    laanwj commented at 12:54 PM on September 2, 2020: member

    Looks like this removes all the remaining DecodeHexTx(…, …, true) in non-test code, besides fundrawtransaction.

11. 
    achow101 commented at 5:06 PM on September 2, 2020: member

    What happens if someone does try a 0 input tx with these? Ideally we would give a meaningful error, but I don't think we do.

12. 
    fanquake commented at 2:15 AM on October 13, 2020: member

    @MarcoFalke could you follow up with achows query:

    What happens if someone does try a 0 input tx with these? Ideally we would give a meaningful error, but I don't think we do.

13. rpc: Adjust witness-tx deserialize error message 3333077823
14. 
    MarcoFalke commented at 1:12 PM on October 13, 2020: member

    @achow101 @fanquake thanks, adjusted error message

15. MarcoFalke added this to the milestone 0.21.0 on Oct 13, 2020
16. 
    achow101 commented at 3:54 PM on October 13, 2020: member

    ACK 33330778230961cfbf2a24de36b5877e395cc596

17. 
    MarcoFalke commented at 8:00 AM on October 14, 2020: member

    @instagibbs / @ajtowns as the author/reviewer of #17775 you might be qualified and interested in reviewing this

18. 
    ajtowns commented at 1:18 AM on October 15, 2020: member

    ACK 33330778230961cfbf2a24de36b5877e395cc596

    Confirmed the RPCs changed are only worth calling if you have inputs, and the error message changes look okay.

19. fanquake merged this on Oct 16, 2020
20. fanquake closed this on Oct 16, 2020

    ---

21. fanquake referenced this in commit 731502a183 on Oct 16, 2020
22. fanquake referenced this in commit bdf15d0d5d on Oct 16, 2020
23. MarcoFalke deleted the branch on Oct 16, 2020
24. fanquake removed the label Needs backport (0.20) on Oct 16, 2020
25. 
    fanquake commented at 4:30 AM on October 16, 2020: member

    Being backported to 0.20 in #20166.

26. fanquake referenced this in commit a7bdf5c3ac on Oct 16, 2020
27. fanquake referenced this in commit 9c714993e9 on Oct 16, 2020
28. 
    fanquake commented at 4:50 AM on October 16, 2020: member

    Added to #20150 for 0.19 backporting.

29. fanquake removed the label Needs backport (0.19) on Oct 16, 2020
30. sidhujag referenced this in commit e0ffdf579c on Oct 16, 2020
31. MarcoFalke referenced this in commit a2fa11f9de on Nov 18, 2020
32. MarkLTZ referenced this in commit 2b539ee0bc on Nov 21, 2020
33. MarkLTZ referenced this in commit e386ce4990 on Nov 21, 2020
34. MarkLTZ referenced this in commit c61e643b75 on Nov 21, 2020
35. MarcoFalke referenced this in commit 5baaea4410 on Dec 2, 2020
36. DrahtBot locked this on Feb 15, 2022

Milestone
0.21.0