net: improve nLastBlockTime and nLastTXTime documentation #19857

1. 
   jonatack commented at 3:56 pm on September 1, 2020: member

   Follow-up to #19731 to help alleviate confusion around nLastBlockTime and nLastTXTime, now also provided by the JSON-RPC API as last_block and last_transaction in getpeerinfo output.

   Thanks to John Newbery, credited in the commit, and to Dave Harding and Adam Jonas during discussions on how to best explain these in this week’s Optech newsletter.

2. net: improve nLastBlockTime and nLastTXTime documentation

   Co-authored-by: John Newbery <john@johnnewbery.com>

   d780293e1e
3. 
   harding commented at 4:20 pm on September 1, 2020: contributor

   ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca . The added documentation matches my reading of the code and answers a question I had after seeing #19731
4. DrahtBot added the label P2P on Sep 1, 2020
5. MarcoFalke added the label Docs on Sep 1, 2020
6. 
   DrahtBot commented at 6:10 pm on September 1, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19829 ([net processing] Move block inventory state to net_processing by jnewbery)
   • #19670 (Protect localhost and block-relay-only peers from eviction by sdaftuar)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   MarcoFalke commented at 5:45 am on September 2, 2020: member

   ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca
8. 
   practicalswift commented at 8:07 am on September 2, 2020: contributor

   ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca

   Great to see Optech collaboration resulting in improved documentation!

9. 
   0xB10C commented at 8:51 am on September 2, 2020: member

   ACK d780293e1ee0f9e66bd2d88914694c17f9aaa0ca
10. fanquake merged this on Sep 2, 2020
11. fanquake closed this on Sep 2, 2020

    ---

12. jonatack deleted the branch on Sep 2, 2020
13. Fabcien referenced this in commit 610fc886e8 on Mar 22, 2021
14. PastaPastaPasta referenced this in commit 84fda17304 on Sep 17, 2021
15. PastaPastaPasta referenced this in commit d109cccf0b on Sep 24, 2021
16. kittywhiskers referenced this in commit 6602c7ef63 on Oct 12, 2021
17. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack harding DrahtBot MarcoFalke practicalswift 0xB10C

Labels
Docs P2P