qa: Fixes failing functional test by changing version #19859

pull n-thumann wants to merge 1 commits into bitcoin:master from n-thumann:qa-fix-wrong-version changing 3 files +5 −5
  1. n-thumann commented at 12:20 PM on September 2, 2020: contributor

    As of https://github.com/bitcoin/bitcoin/commit/0374e821bd9e9498ce9c03aa8e5435870019978b v0.17.2 is downloaded instead of v0.17.1 for functional testing. This causes test/functional/feature_backwards_compatibility.py to fail, because it requires v0.17.1.

    Steps to reproduce: Run test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.1 v0.16.3 v0.15.2. It cannot be downloaded at all because the sha256sum is missing here. Or adjust the command and run test/get_previous_releases.py -b v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2, then run test/functional/test_runner.py feature_backwards_compatibility. It´ll fail because the test is missing v0.17.1.

    This PR changes v0.17.1 to v0.17.2 in this test and in a few comments.

  2. qa: Changes v0.17.1 to v0.17.2 6de9429087
  3. fanquake added the label Tests on Sep 2, 2020
  4. DrahtBot commented at 5:28 PM on September 2, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19332 (test: Fix intermittent test failure in feature_backwards_compatibility by MarcoFalke)
    • #15454 (Remove the automatic creation and loading of the default wallet by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. fanquake approved
  6. fanquake commented at 4:14 AM on September 3, 2020: member

    ACK 6de942908726480fb2919ed1f1b7906a63ec576d - looks correct. Surprised this wasn't caught/part of #19813. In future you could add any explanations & extra info as part of your commit message as well (even though PR descriptions are included as part of the merge).

  7. laanwj commented at 11:32 AM on September 3, 2020: member

    Good first time contribution! ACK 6de942908726480fb2919ed1f1b7906a63ec576d I checked that there are no lingering 0.17.1 mentions left.

  8. laanwj merged this on Sep 3, 2020
  9. laanwj closed this on Sep 3, 2020

  10. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me