build: Fix target name #19868

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200904-make changing 1 files +1 −1

hebasto commented at 10:40 AM on September 4, 2020: member
It seems like a typo :) This PR:
- fixes errors when building a package in depends for HOST=x86_64-apple-darwin16 (fix #19799)
- is a correct alternative to https://github.com/bitcoin/bitcoin/pull/19764/commits/d25e0e308f51f6b995e5d0033224c424dc8afc2c from #19764
hebasto commented at 10:40 AM on September 4, 2020: member

cc @theuni @dongcarl @fanquake
fanquake added the label Build system on Sep 4, 2020
hebasto commented at 1:09 PM on September 5, 2020: member

cc @icota
icota commented at 1:28 PM on September 5, 2020: contributor

I can confirm https://github.com/bitcoin/bitcoin/pull/19868/commits/3eb789c7ea9714cb7e70a7b06eb8abb9aaf33435 fixes #19799 but don't have the experience to weigh in if it's more correct than https://github.com/bitcoin/bitcoin/commit/d25e0e308f51f6b995e5d0033224c424dc8afc2c
laanwj commented at 12:35 PM on September 8, 2020: member

Your PR description is a bit terse. Can you please explain why you think it was a typo, and why it is correct alternative to that other commit?
hebasto commented at 12:44 PM on September 8, 2020: member

@laanwj

Your PR description is a bit terse. Can you please explain why you think it was a typo...

$(package)_unpacked targets are not used as prerequisites for other targets. It was naturally to admit that this line is a remnant from some previous state of work before it was merged.

... and why it is correct alternative to that other commit?

Because of the initial intention of this line that is expressed in the comment: https://github.com/bitcoin/bitcoin/blob/3eb789c7ea9714cb7e70a7b06eb8abb9aaf33435/depends/funcs.mk#L267

theuni commented at 4:34 PM on September 16, 2020: member

@hebasto is absolutely correct here. Thanks for tracking this down!

From IRC Build meeting today:

<cfields> Heh, definitely a typo. Conceptually, that should be "_extracted".
<cfields> Well, I'm not sure if _extracted will actually work. But that's definitely what I intended.
<cfields> Conceptually it means: never start working on a target package (first step is extraction) before all build packages are done.

So Concept ACK, but I think it should be _extracted rather than _configured (assuming that works as intended).

build: Fix target name 7a89f2e6c5
hebasto force-pushed on Sep 16, 2020
hebasto commented at 5:06 PM on September 16, 2020: member
Updated 3eb789c7ea9714cb7e70a7b06eb8abb9aaf33435 -> 7a89f2e6c539a54bcaa24bff41aae3910244ad3d (pr19868.01 -> pr19868.02, diff):
- addressed @theuni's comment:
So Concept ACK, but I think it should be _extracted rather than _configured (assuming that works as intended).
icota commented at 10:10 AM on September 17, 2020: contributor

tACK https://github.com/bitcoin/bitcoin/pull/19868/commits/7a89f2e6c539a54bcaa24bff41aae3910244ad3d
dongcarl commented at 3:39 PM on September 22, 2020: member

Code Review ACK 7a89f2e6c539a54bcaa24bff41aae3910244ad3d

Planning on rebasing #19764 on top of this
MarcoFalke added the label Needs gitian build on Sep 22, 2020
MarcoFalke added the label Needs Guix build on Sep 22, 2020
theuni commented at 8:45 PM on September 22, 2020: member

I was a bit hesitant to simply "fix" this typo, since the intended behavior has never actually executed. But it seems that the intended behavior was necessary and correct after all.

Lightly tested locally, corner cases like make download still work as expected.

ACK 7a89f2e6c539a54bcaa24bff41aae3910244ad3d.

DrahtBot commented at 4:00 PM on September 23, 2020: member

Guix builds

File	commit d692d192cda37fda6359ad0736b85de20383db73<br>(master)	commit 16d4e8c2d81ecfefeaf68c60b58437afbd7807c5<br>(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`d52c4e3d8a38f1a5...`	`c15710d27c08f374...`
*-aarch64-linux-gnu.tar.gz	`8419041004980d09...`	`455425d8c6e3b322...`
*-arm-linux-gnueabihf-debug.tar.gz	`1a6bede290e13a69...`	`436fecf6725786f6...`
*-arm-linux-gnueabihf.tar.gz	`e0244cb3da6ad51c...`	`43b8d3214d302faa...`
*-riscv64-linux-gnu-debug.tar.gz	`a1c5de402d16509c...`	`3c77c243cd7e689c...`
*-riscv64-linux-gnu.tar.gz	`7982a6d4980819d3...`	`cb711b140049800b...`
*-win-unsigned.tar.gz	`6d76e16cdac6231d...`	`b9e07a19f7dae703...`
*-win64-debug.zip	`4094660d64808dc2...`	`15530c77944dffdc...`
*-win64-setup-unsigned.exe	`d4934bf07e3f8e1d...`	`a76c2373d8ea1583...`
*-win64.zip	`5f15fd3d01ed6961...`	`e9f7de70f1a315a1...`
*-x86_64-linux-gnu-debug.tar.gz	`67c6d73129600061...`	`9bea9f21089546c9...`
*-x86_64-linux-gnu.tar.gz	`5ffb9762774ea350...`	`e8337088cfbe6ec0...`
*.tar.gz	`e4f8f5b6de99908b...`	`17e4253917edc548...`
guix_build.log	`b7cdd12ef881f756...`	`b4741f43af2ac936...`
guix_build.log.diff		`f163c7f2612b3f93...`

DrahtBot removed the label Needs Guix build on Sep 23, 2020
MarcoFalke merged this on Sep 23, 2020
MarcoFalke closed this on Sep 23, 2020
sidhujag referenced this in commit c283427bc1 on Sep 23, 2020
hebasto deleted the branch on Sep 23, 2020

DrahtBot commented at 12:38 PM on September 24, 2020: member

Gitian builds

File	commit 8235dca6210dab8e9657c0b592ab928554155082<br>(master)	commit 475d0ad3f464aab8d942c2c5f3e4a5e7c9e07aa5<br>(master and this pull)
*-osx-unsigned.dmg	`8d6680d8c04f8570...`	`28daae3ff51ad9e6...`
*-osx64.tar.gz	`24774d4b21b0e444...`	`aa7ffadc2aab4cff...`
*-win64-debug.zip	`03c5319b35a7d2c2...`
*-win64-setup-unsigned.exe	`14abe27de5c2879c...`
*-win64.zip	`4ad37c137fbb2e95...`
*.tar.gz	`bf41b2104c46374a...`	`27fc409585654e51...`
bitcoin-core-osx-0.21-res.yml	`226ad82c7d21669a...`	`a126ec6687ca5e9b...`
bitcoin-core-win-0.21-res.yml	`7dfd6f5b6ecf311b...`
linux-build.log	`8c0f2ea7e28ea0ab...`	`ec83333cc3c01acd...`
osx-build.log	`01bb9cfded92b87f...`	`db704a8ae7582fca...`
win-build.log	`54238ee2ba263f2a...`	`dd660a907f531de5...`
*-aarch64-linux-gnu-debug.tar.gz		`035552f5806004fe...`
*-aarch64-linux-gnu.tar.gz		`8b42e7b1f7cf5dfc...`
*-arm-linux-gnueabihf-debug.tar.gz		`a69c580d805198a5...`
*-arm-linux-gnueabihf.tar.gz		`9092465f064123c8...`
*-riscv64-linux-gnu-debug.tar.gz		`ebb8c8c252d9a253...`
*-riscv64-linux-gnu.tar.gz		`ab9b38d027cd4f74...`
*-x86_64-linux-gnu-debug.tar.gz		`d4714a1d98b9cc24...`
*-x86_64-linux-gnu.tar.gz		`1d672a67f3179cfa...`
bitcoin-core-linux-0.21-res.yml		`e1e4faa97cb458fd...`
bitcoin-core-osx-0.21-res.yml.diff		`ec7092ca8553c670...`
linux-build.log.diff		`20d8a618f390ed13...`
osx-build.log.diff		`bfd26091f7aedf2f...`
win-build.log.diff		`a6833952c7e4ab0e...`

DrahtBot removed the label Needs gitian build on Sep 24, 2020

fanquake commented at 2:08 AM on September 25, 2020: member

Was wondering why the Windows builds seemed to fail here, but turns out the bot just ran out of space:

+ find bitcoin-475d0ad3f464/bin -type f -executable -print0
/usr/bin/x86_64-w64-mingw32-objcopy:bitcoin-475d0ad3f464/bin/test_bitcoin.exe.dbg[.debug_info]: No space left on device