RPC: Forbid RPC username == RPC password #1987

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:no-pw-match changing 1 files +3 −1

jgarzik commented at 6:42 AM on November 5, 2012: contributor

Added security measure.
Diapolo commented at 6:46 AM on November 5, 2012: none

ACK, security measures are always a nice addition.
gavinandresen commented at 7:12 PM on November 5, 2012: contributor

ACK
sipa commented at 11:13 PM on November 5, 2012: member

I'm not sure this will help, but ACK.
BitcoinPullTester commented at 3:56 AM on November 6, 2012: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/b1080c44840e8253ef353725e27a7626eb8a66df for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
3. The test suite fails on either Linux i386 or Win32
4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
TheBlueMatt commented at 8:09 PM on November 7, 2012: member

Sorry, that was a timeout due to slow jenkins server..., Ill get this retested (and fix the false negatives here)
RPC: Forbid RPC username == RPC password
Added security measure.
7e1610d51e
jgarzik referenced this in commit 34ea321ccd on Nov 16, 2012
jgarzik merged this on Nov 16, 2012
jgarzik closed this on Nov 16, 2012
laudney referenced this in commit 69c2b06276 on Mar 19, 2014
jgarzik deleted the branch on Aug 24, 2014
KolbyML referenced this in commit 4ee2ad2e09 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors