ci: Double tsan CPU and Memory to avoid global timeout #19881

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2008-ciGlobalTimeout changing 1 files +3 −0

MarcoFalke commented at 12:11 PM on September 5, 2020: member

Fix #19864
ci: Double tsan CPU and Memory to avoid global timeout fa8e148714
MarcoFalke commented at 12:12 PM on September 5, 2020: member

https://github.com/bitcoin/bitcoin/blob/416efcb7ab4545d65c675338065aaaa46f800748/.cirrus.yml#L3
in .cirrus.yml:62 in fa8e148714
```
  55 | @@ -56,7 +56,10 @@ task:
  56 |    << : *GLOBAL_TASK_TEMPLATE
  57 |    container:
  58 |      image: ubuntu:focal
  59 | +    cpu: 4  # Double CPU and Memory to avoid timeout
  60 | +    memory: 16G
  61 |    env:
  62 | +    MAKEJOBS: "-j8"
```
hebasto commented at 12:56 PM on September 5, 2020:

cpu: 4, MAKEJOBS: "-j8" and memory: 16G are interconnected. Is there any justification that that combination is optimal?
MarcoFalke commented at 1:01 PM on September 5, 2020:

MAKEJOBS is also used to run the functional tests in ci in parallel. To use maximum CPU during functional tests, at least num_cpu * 2 needs to be passed.

$ ./test/functional/test_runner.py --help|grep parallel --jobs JOBS, -j JOBS how many test scripts to run in parallel. Default=4.
hebasto commented at 1:03 PM on September 5, 2020:

To use maximum CPU during functional tests, at least num_cpu * 2 needs to be passed.

TIL.

MarcoFalke commented at 1:06 PM on September 5, 2020:

At least this is what I found out a while back. Might have changed in the meantime
hebasto commented at 12:56 PM on September 5, 2020: member

Concept ACK.
hebasto approved
hebasto commented at 1:06 PM on September 5, 2020: member
ACK fa8e1487144eab237ffd291397355ef4801f46f8, according to https://cirrus-ci.org/guide/linux/ the limits are:
- 8 CPUs
- 24 GB of memory
DrahtBot added the label Tests on Sep 5, 2020
practicalswift commented at 7:12 PM on September 5, 2020: contributor

ACK fa8e1487144eab237ffd291397355ef4801f46f8 -- patch looks correct
MarcoFalke merged this on Sep 6, 2020
MarcoFalke closed this on Sep 6, 2020
MarcoFalke deleted the branch on Sep 6, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19864 Spurious CI failure: cirrus CI timeout