refactor: remove unused header <arpa/inet.h> in protocol.cpp #19890

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20200823-refactor-remove-unsused-include-in-protocol-cpp changing 1 files +0 −4

theStack commented at 1:02 AM on September 6, 2020: member

There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed.
refactor: remove unused header <arpa/inet.h> in protocol.cpp 2f79e9d002
fanquake added the label Refactoring on Sep 6, 2020
practicalswift commented at 9:52 AM on September 6, 2020: contributor

ACK 2f79e9d00206a5230377f49be7b2f6da70f80417 -- patch looks correct and CI is happy

Thanks a lot for removing legacy cruft! Future generations of Bitcoin Core developers will thank you! :)
promag commented at 10:01 AM on September 6, 2020: member

Code review ACK 2f79e9d00206a5230377f49be7b2f6da70f80417.
epson121 commented at 11:13 AM on September 6, 2020: none

Code review ACK 2f79e9d00206a5230377f49be7b2f6da70f80417

I've looked into possible remaining usage of any types, structures, macros or functions defined in arpa/inet.h in changed file, and there aren't any (man page)
laanwj commented at 11:15 AM on September 6, 2020: member

ACK 2f79e9d00206a5230377f49be7b2f6da70f80417 also verified that no hton* or inet_ functions are used in protocol.cpp (nor in_addr)
laanwj merged this on Sep 6, 2020
laanwj closed this on Sep 6, 2020
theStack deleted the branch on Dec 1, 2020
PastaPastaPasta referenced this in commit 8c218b5383 on Jun 27, 2021
PastaPastaPasta referenced this in commit 38a3f8319b on Jun 28, 2021
PastaPastaPasta referenced this in commit 67af26c4e4 on Jun 29, 2021
PastaPastaPasta referenced this in commit 1080fb5cee on Jul 1, 2021
PastaPastaPasta referenced this in commit 86e35f6367 on Jul 1, 2021
PastaPastaPasta referenced this in commit a08693f8eb on Jul 15, 2021
PastaPastaPasta referenced this in commit 2ede3202ef on Jul 16, 2021
Fabcien referenced this in commit 47b8417175 on Sep 23, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#735 Network stack refactor