Fixes #19603: As suggested by practicalswift, instead of always printing <n> of the last 100 blocks have unexpected version
as a warning appended to UpdateTip, it is now printed in the validation log category and therefore only visible with -debug=validation
enabled.
Before:
2020-09-06T15:56:00Z UpdateTip: new best=00000000000000000001b2872e107a98b57913120e5c6c87ce2715a34c40adf8 height=646969 version=0x20400000 log2_work=92.261571 tx=565651941 date='2020-09-06T10:35:36Z' progress=0.999888 cache=32.2MiB(237417txo) warning='72 of last 100 blocks have unexpected version'
After:
2020-09-06T16:31:26Z UpdateTip: new best=0000000000000000000b3bd786dc42745dd7be4a8c695500a04518cb9e2f4dc1 height=646971 version=0x20000000 log2_work=92.261607 tx=565655901 date='2020-09-06T10:57:19Z' progress=0.999883 cache=3.8MiB(27550txo)
2020-09-06T16:31:26Z 71 of last 100 blocks have unexpected version
Ran unit & functional tests, confirmed that the warning is now only printed when validation category is enabled.