gui: Add Tor icon #19926

1. 
   hebasto commented at 2:24 pm on September 9, 2020: member

   This PR is submitted not to the GUI repo because it touches files out of the src/qt directory.

   Behavior:

   • the Tor icon is showed in the status bar iif all peer connections are made via Tor (credits to Sjors, these conditions could be achieved with -onlynet=onion, -listen=0, and -listenonion=1 options)
   • a click on the Tor icon opens the “Network” tab of the “Options” dialog

   Designer: Bosch-0 Icon PNG file is optimized (credits to jonasschnelli).

   Fix #7734 Fix https://github.com/bitcoin-core/gui/issues/58

   Screenshots:

2. gui: Add Tor icon

   Co-authored-by: bosch <bosch5@pm.me>

   8acdea2b08
3. 
   MarcoFalke commented at 2:41 pm on September 9, 2020: member

   Would it make sense to expose the same boolean on RPC?

   Btw, the latest optimize png script is now here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py

   Also, it would be good to add the svg source in case alternative versions need to be created.

4. 
   hebasto commented at 2:55 pm on September 9, 2020: member

   Would it make sense to expose the same boolean on RPC?

   With which command name?

5. 
   kristapsk commented at 2:59 pm on September 9, 2020: contributor

   Would it make sense to expose the same boolean on RPC?

   I think that’s a good idea.

6. 
   kristapsk commented at 3:01 pm on September 9, 2020: contributor

   Would it make sense to expose the same boolean on RPC?

   With which command name?

   getnetworkinfo?

7. DrahtBot added the label Build system on Sep 9, 2020
8. DrahtBot added the label GUI on Sep 9, 2020
9. 
   fanquake commented at 0:47 am on September 10, 2020: member

   This PR is submitted not to the GUI repo because it touches files out of the src/qt directory.

   Given this is just node.cpp/h and the changes are trivial, I think this should be in the GUI repo.

10. in src/qt/bitcoingui.cpp:1333 in 8acdea2b08

    1328+    if (clientModel->hasTorOnlyConnections()) {
    1329+        m_tor_icon->setPixmap(platformStyle->SingleColorIcon(":/icons/tor_connected").pixmap(STATUSBAR_ICONSIZE, STATUSBAR_ICONSIZE));
    1330+        m_tor_icon->setToolTip(tr("All connections are <b>via Tor</b> only"));
    1331+        m_tor_icon->show();
    1332+    }
    1333+}
    

    ---

    ---

    

    benthecarman commented at 5:26 am on September 10, 2020:

    Should this have an else case:

    0else {
    1	m_tor_icon->hide();
    2}
    

    ---

    

    hebasto commented at 8:32 am on September 10, 2020:

    Done in https://github.com/bitcoin-core/gui/pull/86.
11. 
    hebasto commented at 8:33 am on September 10, 2020: member

    @fanquake

    Given this is just node.cpp/h and the changes are trivial, I think this should be in the GUI repo.

    Moved into https://github.com/bitcoin-core/gui/pull/86. @MarcoFalke

    Also, it would be good to add the svg source in case alternative versions need to be created.

    Done in https://github.com/bitcoin-core/gui/pull/86.

12. hebasto closed this on Sep 10, 2020

    ---

13. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto MarcoFalke kristapsk fanquake benthecarman

Labels
GUI Build system