Test: Cover "change_type" option of "walletcreatefundedpsbt" RPC #19947

1. 
   guggero commented at 3:28 PM on September 12, 2020: contributor

   Increases test coverage of the walletcreatefundedpsbt RPC.

   Tests the following combinations:

   • Make sure the global option -changetype is used as the default value for the change_type option if not specified.
   • Make sure the global option -changetype can be overwritten by explicitly setting the change_type option of the walletcreatefundedpsbt RPC call.
   • Make sure the options change_type and changeAddress are mutually exclusive.
2. 
   practicalswift commented at 4:42 PM on September 12, 2020: contributor

   Concept ACK

   Very nice first-time contribution @guggero! Hope to see more contributions from you in the future. Warm welcome! :)

3. DrahtBot added the label Tests on Sep 12, 2020
4. kristapsk approved
5. 
   kristapsk commented at 11:10 PM on September 12, 2020: contributor

   ACK b371aa3bbd9a0b2633cc46c3925181da17bdc403

6. 
   michaelfolkson commented at 10:20 AM on September 13, 2020: contributor

   Concept ACK

   Are you happy for this to have a "good first review" label @guggero? It would mean the PR is noisier than normal and you might have to answer more basic questions than you otherwise would :)

7. 
   guggero commented at 6:39 AM on September 14, 2020: contributor

   Thank you all for the (concept) ACKs and the warm welcome :)

   I think the label "good first review" is a great idea, @michaelfolkson. I'm happy to answer any and all questions around this PR (that I know the answer to). You're welcome to add the label.

8. MarcoFalke requested review from Sjors on Oct 2, 2020
9. MarcoFalke requested review from achow101 on Oct 2, 2020
10. 
    MarcoFalke commented at 11:33 AM on October 2, 2020: member

    Needs rebase

                                       AssertionError: Expected substring not found in error message:
    
                                       substring: 'both changeAddress and address_type'
    
                                       error message: 'Cannot specify both change address and address type options'.
    

11. test: Assert PSBT change type

    Make sure the wallet's default change type is respected by default when
    funding a PSBT but can be overwritten by the "change_type" option.

    64bc5efd39
12. test: Assert exclusive PSBT funding options

    Make sure the options "change_type" and "changeAddress" of the
    walletcreatefundedpsbt RPC cannot both be specified a the same time.

    a56e9f5670
13. guggero force-pushed on Oct 2, 2020
14. 
    guggero commented at 3:24 PM on October 2, 2020: contributor

    Rebased and fixed the error message check.

15. 
    achow101 commented at 3:57 PM on October 2, 2020: member

    ACK a56e9f5670136b29e48aabfc7f38569222fe4635

16. MarcoFalke merged this on Oct 5, 2020
17. MarcoFalke closed this on Oct 5, 2020

    ---

18. guggero deleted the branch on Oct 5, 2020
19. sidhujag referenced this in commit 38eabdaece on Oct 6, 2020
20. DrahtBot locked this on Feb 15, 2022

Review Requested
Sjorsachow101