Remove static log message Initializing chainstate Chainstate [ibd] @ height -1 (null).
AFAICT chainstate->ToString() will always equal "Chainstate [ibd] @ height -1 (null)" here which makes the log message neither relevant nor interesting :)
log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" #19984
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:logging-should-not-be-static-department changing 1 files +0 −1-
practicalswift commented at 3:46 PM on September 20, 2020: contributor
-
log: Remove static log message "Initializing chainstate Chainstate [ibd] @ height -1 (null)" f22d6a1142
- hebasto approved
-
hebasto commented at 4:44 PM on September 20, 2020: member
ACK f22d6a11423a4462196de24cd68e7f45513cc001, I agree that the removed log message in its current state is cryptic and useless.
- DrahtBot added the label Utils/log/libs on Sep 20, 2020
-
MarcoFalke commented at 5:41 PM on September 20, 2020: member
I'd presume the log will say whether a background chainstate was initialized (assumeutxo)
-
practicalswift commented at 6:07 PM on September 20, 2020: contributor
@jamesob Will this error message be relevant when running with default logging once
assumeutxois in place? :) If so, when should we print it: whenheight != -1? -
laanwj commented at 3:10 PM on September 21, 2020: member
Concept ACK on removing or improving this log message. It's way too cryptic for a message logged in the non-debug category, and doesn't seem to contain any useful information just the details of a newly constructed object.
I'd presume the log will say whether a background chainstate was initialized (assumeutxo)
That would be useful to log, though.
ACK f22d6a11423a4462196de24cd68e7f45513cc001
-
promag commented at 10:42 AM on September 22, 2020: member
ACK f22d6a11423a4462196de24cd68e7f45513cc001, just get rid of it.
- laanwj merged this on Sep 29, 2020
- laanwj closed this on Sep 29, 2020
- sidhujag referenced this in commit bbf1f3e5f6 on Sep 29, 2020
- practicalswift deleted the branch on Apr 10, 2021
- Fabcien referenced this in commit c0772dbd60 on Oct 29, 2021
- PastaPastaPasta referenced this in commit 9098a53a4f on Jun 7, 2022
- PastaPastaPasta referenced this in commit 5a45119d02 on Jun 7, 2022
- PastaPastaPasta referenced this in commit f5831cbbdb on Jun 7, 2022
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels