test: use explicit p2p objects where available #20022

pull guggero wants to merge 1 commits into bitcoin:master from guggero:p2p-conn-rename changing 2 files +2 −2

guggero commented at 8:49 AM on September 26, 2020: contributor

This is a follow-up patch to #19804 as suggested by MarcoFalke (https://github.com/bitcoin/bitcoin/pull/19804#discussion_r494950062).

To make the intent of the tests easier to understand, we reference the p2p connection objects by their explicit names instead of the p2ps array.

test: use explicit p2p objects where available

To make the intent of the tests easier to understand, we reference the
p2p connection objects by their explicit names instead of the p2ps array.

0fcaf73199

DrahtBot added the label Tests on Sep 26, 2020
practicalswift commented at 10:29 AM on September 26, 2020: contributor

Concept ACK

Welcome (again) as a contributor @guggero! :)
theStack approved
theStack commented at 10:37 AM on September 26, 2020: member

ACK 0fcaf731997c4989b869e42d8990f742637799c2 Identified the remaining p2ps[] accesses via git grep "\.p2ps\[" and verified that the tests p2p_getdata.py and wallet_resendwallettransactions.py have explicit p2p objects that can be used instead. The affected tests passed locally. 👌
MarcoFalke merged this on Sep 26, 2020
MarcoFalke closed this on Sep 26, 2020
guggero deleted the branch on Sep 26, 2020
Fabcien referenced this in commit 1217912166 on Oct 14, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels