[release-process] version number is outdated in bitcoin_config.h #20031

1. 
   decryp2kanon commented at 6:43 AM on September 29, 2020: contributor

   master branch is outdated https://github.com/bitcoin/bitcoin/blob/7ea649946daa421ed7dfa478cbb0bcf2de3cc2f8/build_msvc/bitcoin_config.h#L256

   0.20.1 release tag is too https://github.com/bitcoin/bitcoin/blob/7ff64311bee570874c4f0dfa18f518552188df08/build_msvc/bitcoin_config.h#L268

   what about deleting this option? it seems useless at this moment. PACKAGE_STRING

   

2. fanquake added the label Build system on Sep 29, 2020
3. fanquake added the label Windows on Sep 29, 2020
4. 
   MarcoFalke commented at 7:54 AM on September 29, 2020: member

   cc @sipsorcery

5. 
   sipsorcery commented at 8:19 AM on September 29, 2020: member

   Perhaps we should set the version numbers in the build_msvc/bitcoin_config.h file to 0.99.99, or similar, to indicate that the msvc builds are only ever for development purposes?

6. MarcoFalke added this to the milestone 0.21.0 on Sep 29, 2020
7. 
   laanwj commented at 6:55 PM on October 8, 2020: member

   This seems like an actual oversight as it's mentioned in the release process to update this for master as well. That said, please don't add the version numbers in a zillion different places (that need to be manually updated), it would be more robust if it is derived from one place and only that needs to be updated between releases..

   Let's update it after the 0.21 split-off (whether to 0.22 or 0.99 both is fine with me).

8. fanquake removed this from the milestone 0.21.0 on Nov 12, 2020
9. fanquake added this to the milestone 22.0 on Nov 12, 2020
10. 
    jnewbery commented at 9:59 AM on November 12, 2020: member

    Moving this to 22.0 milestone since nothing needs to happen until after the 0.21 split-off

11. laanwj referenced this in commit 12b89cebdf on Nov 18, 2020
12. laanwj referenced this in commit daf1ebf0b1 on Nov 18, 2020
13. 
    laanwj commented at 10:26 AM on November 18, 2020: member

    Fixed by the latest version bumps.

    I repeat: please, do not add any other new places with the version number. To be honest it's silly that bitcoin_config.h has three of them and not even together in the same place.

14. laanwj closed this on Nov 18, 2020

    ---

15. DrahtBot locked this on Feb 15, 2022

Contributors

decryp2kanonMarcoFalkesipsorcerylaanwjjnewbery

Milestone
22.0