fuzz: Version handshake #20097

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2010-fuzzHandshake changing 1 files +0 −3
  1. MarcoFalke commented at 12:21 pm on October 7, 2020: member

    I don’t see a reason to exclude the version/verack message from the process_messages fuzzer. Whereas including it will have several benefits:

    • Higher coverage (version/verack/handshake/wtxid/…) in net_processing
    • Fuzzer can pick the peer versions instead of relying on a hardcoded constant, might increase search space and coverage even further
  2. fuzz: Version handshake fa76ca3c33
  3. DrahtBot added the label Tests on Oct 7, 2020
  4. MarcoFalke commented at 6:50 am on October 9, 2020: member
  5. MarcoFalke commented at 12:03 pm on October 9, 2020: member
    For reference, it is currently impossible to hit meaningfully the following message types in the fuzzer: if (msg_type == NetMsgType::VERSION) {, if (msg_type == NetMsgType::WTXIDRELAY) {. See https://marcofalke.github.io/btc_cov/fuzz.coverage/src/net_processing.cpp.gcov.html
  6. practicalswift commented at 12:21 pm on October 9, 2020: contributor
    Thanks for the ping! Will review :)
  7. MarcoFalke commented at 11:23 am on October 12, 2020: member
    I’ll explore some ideas on how to increase coverage even further. Closing for now.
  8. MarcoFalke closed this on Oct 12, 2020

  9. MarcoFalke deleted the branch on Oct 12, 2020
  10. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me