doc: Collect release-notes snippets #20107

1. 
   MarcoFalke commented at 1:11 PM on October 8, 2020: member

   Also add a note for #20101

2. doc: Collect release-notes snippets 99992e7832
3. doc: Add release notes for #20101 faa0847dec
4. fanquake added the label Docs on Oct 8, 2020
5. laanwj added this to the milestone 0.21.0 on Oct 8, 2020
6. 
   gwillen commented at 7:26 PM on October 8, 2020: contributor

   Complementing #20101 -- is it worth making the release notes be more explicit about the impact of the "no default wallet" change on RPC users? I.e., clearly spell out that the automatic prompting is only in the GUI, and that RPC users now MUST call createwallet, or loadwallet, or supply -wallet to bitcoind, in order to have a wallet available? (I advocated for putting this information in the error message, but that's somewhat abbreviated; the release notes would be one sensible place for a longer message about it.)

7. 
   MarcoFalke commented at 6:43 AM on October 9, 2020: member

   This is already mentioned in the GUI section and Default Wallet section of the release notes. Anything missing there?

8. 
   gwillen commented at 9:08 AM on October 9, 2020: contributor

   Well, the Default Wallet section says:

   "Bitcoin Core will no longer create an unnamed "" wallet by default when no wallet is specified on the command line or in the configuration files. For backwards compatibility, if an unnamed "" wallet already exists and would have been loaded previously, then it will still be loaded. Users without an unnamed "" wallet and without any other wallets to be loaded on startup will be prompted to either choose a wallet to load, or to create a new wallet."

   So the message here is "GUI users, have no fear, you don't need to worry about this", and it does not mention RPC/CLI users at all. I am suggesting it should say something more explicitly helpful for those users, like: "RPC and CLI users will need to explicitly load a wallet, using either the -wallet= flag to bitcoind, or the loadwallet RPC. (Or create a new wallet using the createwallet RPC.)"

   But it does say that in the error message now, after #20101, so one way or another they'll figure it out eventually.

9. 
   MarcoFalke commented at 9:18 AM on October 9, 2020: member

   I'll leave the notes as is for now. They can be changed easily as needed when they are moved to the wiki next week.

10. fanquake approved
11. 
    fanquake commented at 10:07 AM on October 9, 2020: member

    ACK faa0847dec0f48f8c07c9a4c995bf5f688bb8c1c - no need to bike-shed here as these will all get massaged to death in the wiki anyways.

12. fanquake merged this on Oct 9, 2020
13. fanquake closed this on Oct 9, 2020

    ---

14. MarcoFalke deleted the branch on Oct 9, 2020
15. sidhujag referenced this in commit ec6bbd0b45 on Oct 9, 2020
16. DrahtBot locked this on Feb 15, 2022

Milestone
0.21.0