txrequest announcement warning #20173

issue sidhujag opened this issue on October 17, 2020
  1. sidhujag commented at 3:30 AM on October 17, 2020: none

    Compiling master on bionic x86_64 I get this warning:

    txrequest.cpp:73:21: warning: ‘{anonymous}::Announcement::m_state’ is too small to hold all values of ‘enum class {anonymous}::State’
         State m_state : 3;
    
                     

    Do we do anything about it? You would think 3 bits (8 values) should be enough to store m_state which only has 5 values but maybe because the State enum is a uint8_t its complaining about possibly being too small.

  2. sidhujag added the label Bug on Oct 17, 2020
  3. fanquake commented at 3:31 AM on October 17, 2020: member

    This is being fixed in #20162.

  4. sidhujag commented at 3:32 AM on October 17, 2020: none

    ACK

  5. sidhujag closed this on Oct 17, 2020

  6. DrahtBot locked this on Feb 15, 2022
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me