test: Switch to BIP341's suggested scheme for outputs without script #20189

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202010_taproot_std_noscript changing 1 files +1 −1

sipa commented at 8:53 PM on October 19, 2020: member

BIP341 suggests using HashTapTweak(pubkey) to derive the tweak in case of key-only outputs. The functional test framework currently uses HashTapTweak(pubkey || 0x00...00) instead. Change this.

There is no technical reason to prefer one over the other, but in case someone looks at it for inspiration, it's better to be consistent with the BIP.
Switch to BIP341's suggested scheme for outputs without script 812baaa1f8
DrahtBot added the label Tests on Oct 19, 2020
MarcoFalke renamed this:
~~Switch to BIP341's suggested scheme for outputs without script~~
test: Switch to BIP341's suggested scheme for outputs without script
on Oct 20, 2020
practicalswift commented at 7:41 AM on October 20, 2020: contributor

ConceptACK
laanwj commented at 9:53 AM on October 27, 2020: member

ACK 812baaa1f804a8c848284759c75e5f9d19e942f8 It's good to be consistent with best practices.
sipa commented at 8:41 PM on November 25, 2020: member

ping
instagibbs commented at 2:37 AM on December 24, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/20189/commits/812baaa1f804a8c848284759c75e5f9d19e942f8

matches taproot_output_script definition in BIP341
MarcoFalke merged this on Dec 24, 2020
MarcoFalke closed this on Dec 24, 2020
sidhujag referenced this in commit fc7a9de038 on Dec 24, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels