wallet, refactor: Include headers instead of function declarations #20206
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:201020-headers changing 1 files +2 −2-
hebasto commented at 9:19 pm on October 20, 2020: memberThis PR is a #19077 follow up: #19077 (review)
-
fanquake added the label Wallet on Oct 20, 2020
-
DrahtBot commented at 1:18 am on October 21, 2020: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20275 (wallet: List all wallets in non-SQLite and non-BDB builds by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
MarcoFalke added the label Refactoring on Oct 21, 2020
-
practicalswift commented at 1:02 pm on October 21, 2020: contributorACK 1d5ac6062603e8ed494c8edacbdd314377e83627
-
theStack approved
-
theStack commented at 0:19 am on October 22, 2020: memberACK 1d5ac6062603e8ed494c8edacbdd314377e83627 📄
-
mjdietzx approved
-
mjdietzx commented at 2:03 am on October 29, 2020: contributorACK 1d5ac6062603e8ed494c8edacbdd314377e83627
-
DrahtBot added the label Needs rebase on Oct 29, 2020
-
hebasto force-pushed on Oct 29, 2020
-
hebasto commented at 2:52 pm on October 29, 2020: memberRebased 1d5ac6062603e8ed494c8edacbdd314377e83627 -> e32fb745918604798a25abc8a1f154c742320f83 (pr20206.01 -> pr20206.02) due to the conflict with #20156.
-
DrahtBot removed the label Needs rebase on Oct 29, 2020
-
DrahtBot added the label Needs rebase on Nov 23, 2020
-
wallet, refactor: Include headers instead of function declarations 9dbdb27291
-
hebasto force-pushed on Nov 25, 2020
-
hebasto commented at 2:35 pm on November 25, 2020: memberRebased e32fb745918604798a25abc8a1f154c742320f83 -> 9dbdb2729126d06268b22653b948daf98a435e59 (pr20206.02 -> pr20206.03) due to the conflict with #20202.
-
DrahtBot removed the label Needs rebase on Nov 25, 2020
-
DrahtBot commented at 8:52 am on December 12, 2020: member
🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.
-
DrahtBot added the label Needs rebase on Dec 12, 2020
-
hebasto closed this on Dec 19, 2020
-
hebasto deleted the branch on Dec 19, 2020
-
DrahtBot locked this on Feb 15, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 15:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me